Skip to content

[TM] add spec for FileReaderModule#24904

Closed
ericlewis wants to merge 2 commits into
facebook:masterfrom
ericlewis:spec-FileReaderModule
Closed

[TM] add spec for FileReaderModule#24904
ericlewis wants to merge 2 commits into
facebook:masterfrom
ericlewis:spec-FileReaderModule

Conversation

@ericlewis
Copy link
Copy Markdown
Contributor

Summary

Part of #24875.

Changelog

[General] [Added] - add TM spec for FileReaderModule

Test Plan

Flow passes

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels May 16, 2019
@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label May 16, 2019
@ericlewis ericlewis added the Flow label May 16, 2019
Copy link
Copy Markdown
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @ericlewis in 0e7a2ca.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 22, 2019
M-i-k-e-l pushed a commit to M-i-k-e-l/react-native that referenced this pull request Mar 10, 2020
Summary:
Part of facebook#24875.

## Changelog

[General] [Added] - add TM spec for FileReaderModule
Pull Request resolved: facebook#24904

Reviewed By: fkgozali

Differential Revision: D15391738

Pulled By: rickhanlonii

fbshipit-source-id: 69e6ff53aba2d2227607905e1f70310bdd01d224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Flow Merged This PR has been merged. Native Module Type: Enhancement A new feature or enhancement of an existing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants