Skip to content

[TM] add spec for FileReaderModule #24904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ericlewis wants to merge 2 commits into from
Closed

[TM] add spec for FileReaderModule #24904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b07474
[TM] add spec for FileReaderModule
ericlewis May 16, 2019
66b1b5c
Fix import
ericlewis May 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Libraries/Blob/FileReader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

const EventTarget = require('event-target-shim');
const Blob = require('./Blob');
const {FileReaderModule} = require('../BatchedBridge/NativeModules');
import NativeFileReaderModule from './NativeFileReaderModule';

type ReadyState =
| 0 // EMPTY
Expand Down Expand Up @@ -87,7 +87,7 @@ class FileReader extends EventTarget(...READER_EVENTS) {
readAsDataURL(blob: Blob) {
this._aborted = false;

FileReaderModule.readAsDataURL(blob.data).then(
NativeFileReaderModule.readAsDataURL(blob.data).then(
(text: string) => {
if (this._aborted) {
return;
Expand All @@ -108,7 +108,7 @@ class FileReader extends EventTarget(...READER_EVENTS) {
readAsText(blob: Blob, encoding: string = 'UTF-8') {
this._aborted = false;

FileReaderModule.readAsText(blob.data, encoding).then(
NativeFileReaderModule.readAsText(blob.data, encoding).then(
(text: string) => {
if (this._aborted) {
return;
Expand Down
21 changes: 21 additions & 0 deletions Libraries/Blob/NativeFileReaderModule.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
/**
* Copyright (c) Facebook, Inc. and its affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow
* @format
*/

'use strict';

import type {TurboModule} from 'RCTExport';
import * as TurboModuleRegistry from 'TurboModuleRegistry';

export interface Spec extends TurboModule {
+readAsDataURL: (data: Object) => Promise<string>;
+readAsText: (data: Object, encoding: string) => Promise<string>;
}

export default TurboModuleRegistry.getEnforcing<Spec>('FileReaderModule');