Skip to content

add warnings for DatePickerIOS and DatePickerAndroid#25374

Closed
ecreeth wants to merge 3 commits into
facebook:masterfrom
ecreeth:add-warnings
Closed

add warnings for DatePickerIOS and DatePickerAndroid#25374
ecreeth wants to merge 3 commits into
facebook:masterfrom
ecreeth:add-warnings

Conversation

@ecreeth
Copy link
Copy Markdown
Contributor

@ecreeth ecreeth commented Jun 24, 2019

Summary

DatePickerIOS and DatePickerAndroid have been merged as part of Lean Core. See repo

Changelog

[General] [Deprecate] - Warning for DatePickerIOS and DatePickerAndroid

Test Plan

Warning prints when user imports DatePickerIOS or DatePickerAndroid

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 24, 2019
@pull-bot
Copy link
Copy Markdown

pull-bot commented Jun 24, 2019 •
edited
Loading

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 93914b0

cpojer
cpojer approved these changes Jun 25, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

facebook-github-bot
facebook-github-bot approved these changes Jun 25, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@Swaagie
Copy link
Copy Markdown

Swaagie commented Jun 26, 2019 •
edited
Loading

Nice work! TimePickerAndroid https://github.com/facebook/react-native/pull/25374/files#diff-834d77988fd4294e13e3e35533b3e248R278 should get the same message. See https://github.com/react-native-community/react-native-datetimepicker/tree/master/android/src/main/java/com/reactcommunity/rndatetimepicker both are ported and can be used by a simple mode switch to make it comparable to iOS feature-wise.

@ecreeth
Copy link
Copy Markdown
Contributor Author

ecreeth commented Jun 26, 2019

Done! the warning for TimePickerAndroid has been added!

@ecreeth ecreeth changed the title add warnings for DatePickerIOS and DatePickerAndroid add warnings for DatePickerIOS, DatePickerAndroid and TimePickerAndroid Jun 26, 2019
@cpojer
Copy link
Copy Markdown
Contributor

cpojer commented Jun 26, 2019

Actually, could you send a separate Pull Request with the new warning? This change has already landed internally at FB but unfortunately wasn't synced out to GitHub yet for some reason.

@ecreeth
Copy link
Copy Markdown
Contributor Author

ecreeth commented Jun 26, 2019

@cpojer Of course!

@ecreeth ecreeth changed the title add warnings for DatePickerIOS, DatePickerAndroid and TimePickerAndroid add warnings for DatePickerIOS and DatePickerAndroid Jun 26, 2019
@react-native-bot
Copy link
Copy Markdown
Collaborator

react-native-bot commented Jun 26, 2019

This pull request was successfully merged by @ecreeth in c749eaf.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jun 26, 2019
M-i-k-e-l pushed a commit to M-i-k-e-l/react-native that referenced this pull request Mar 10, 2020
@ecreeth @M-i-k-e-l
add warnings for DatePickerIOS and DatePickerAndroid (facebook#25374)
1f55c34 
Summary:
`DatePickerIOS` and `DatePickerAndroid` have been merged as part of Lean Core. See [repo](https://github.com/react-native-community/react-native-datetimepicker)

## Changelog

[General] [Deprecate] -  Warning for `DatePickerIOS` and `DatePickerAndroid`
Pull Request resolved: facebook#25374

Test Plan: Warning prints when user imports `DatePickerIOS` or `DatePickerAndroid`

Differential Revision: D15983829

Pulled By: cpojer

fbshipit-source-id: dfa35e204bb133a1b8de67c25abaa4338b956901
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@cpojer cpojer cpojer approved these changes

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Component: PickerIOS Merged This PR has been merged. Platform: Android Android applications. Platform: iOS iOS applications.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ecreeth @pull-bot @Swaagie @cpojer @react-native-bot @facebook-github-bot