Skip to content

add warnings for DatePickerIOS and DatePickerAndroid #25374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ecreeth wants to merge 3 commits into from
Closed

add warnings for DatePickerIOS and DatePickerAndroid #25374

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d27bd3
add warnings for DatePickerIOS and DatePickerAndroid
ecreeth Jun 24, 2019
543b64d
add warning for TimePickerAndroid
ecreeth Jun 26, 2019
93914b0
revert TimePickerAndroid warning
ecreeth Jun 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Libraries/react-native/react-native-implementation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@ module.exports = {
return require('../Components/CheckBox/CheckBox');
},
get DatePickerIOS() {
warnOnce(
'DatePickerIOS-merged',
'DatePickerIOS has been merged with DatePickerAndroid and TimePickerAndroid and will be removed in a future release. ' +
"It can now be installed and imported from '@react-native-community/datetimepicker' instead of 'react-native'. " +
'See https://github.com/react-native-community/react-native-datetimepicker',
);
return require('../Components/DatePicker/DatePickerIOS');
},
get DrawerLayoutAndroid() {
Expand Down Expand Up @@ -181,6 +187,12 @@ module.exports = {
return require('../Components/Clipboard/Clipboard');
},
get DatePickerAndroid() {
warnOnce(
'DatePickerAndroid-merged',
'DatePickerAndroid has been merged with DatePickerIOS and TimePickerAndroid and will be removed in a future release. ' +
"It can now be installed and imported from '@react-native-community/datetimepicker' instead of 'react-native'. " +
'See https://github.com/react-native-community/react-native-datetimepicker',
);
return require('../Components/DatePickerAndroid/DatePickerAndroid');
},
get DeviceInfo() {
Expand Down