use iPhone X instead of iPhone 6s#27295
Closed
elicwhite wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D18645860 |
|
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D18645860 |
elicwhite
force-pushed
the
export-D18645860
branch
from
b36288f to
4832879
Compare
Summary: Pull Request resolved: facebook#27295 Changelog: [Testing] [iOS] Use iPhone X in end to end tests since newer versions of iOS do not run on iPhone 6s Reviewed By: TheSavior Differential Revision: D18645860 fbshipit-source-id: 01bd0e5f4a903c1a77772d321f411ff20c627d6a
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D18645860 |
elicwhite
force-pushed
the
export-D18645860
branch
from
4832879 to
384d496
Compare
hramos
added a commit
to hramos/react-native
that referenced
this pull request
Dec 9, 2019
Summary: Pull Request resolved: facebook#27434 Pull Request resolved: facebook#27295 - Use latest Xcode version in both internal and external tests. - Switch to iPhone 11 as target test simulator as it is included in a default Xcode 11 install. - Update snapshot reference images to use iPhone 11 test device. - `testNotUTF8Convertible` disabled as `NSString`'s `-initWithBytes:length:encoding:` currently segfaults on iOS 13. Differential Revision: D18849584 fbshipit-source-id: 7e9eaf35f91ed5ec38814cf563ea1dc5f9b0d18c
Contributor
|
Closing as we will likely make changes to this as part of the update to use Xcode 11 in our tooling. |
hramos
added a commit
to hramos/react-native
that referenced
this pull request
Jan 14, 2020
Summary: Pull Request resolved: facebook#27434 Pull Request resolved: facebook#27295 - Use Xcode version 11.2.1 in both internal and external tests. - Update snapshot reference images to use iPhone 8 test device. Xcode 11.3.0 will be available in Sandcastle in the next week or so. Changelog: [Internal] - Bump Xcode version used in tests to 11.2.1. [Internal] - Update iOS Snapshots. Differential Revision: D18849584 fbshipit-source-id: 6efbd32c607702bb7291d462b71840bbef25def7
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 14, 2020
Summary: Pull Request resolved: #27434 Pull Request resolved: #27295 - Use Xcode version 11.2.1 in both internal and external tests. - Update snapshot reference images to use iPhone 8 test device. Xcode 11.3.0 will be available in Sandcastle in the next week or so. Changelog: [Internal] - Bump Xcode version used in tests to 11.2.1. [Internal] - Update iOS Snapshots. Reviewed By: cs01 Differential Revision: D18849584 fbshipit-source-id: 9e3b92f080a4dc6a15dac0535b7562ff6a5c08a9
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: Pull Request resolved: facebook#27434 Pull Request resolved: facebook#27295 - Use Xcode version 11.2.1 in both internal and external tests. - Update snapshot reference images to use iPhone 8 test device. Xcode 11.3.0 will be available in Sandcastle in the next week or so. Changelog: [Internal] - Bump Xcode version used in tests to 11.2.1. [Internal] - Update iOS Snapshots. Reviewed By: cs01 Differential Revision: D18849584 fbshipit-source-id: 9e3b92f080a4dc6a15dac0535b7562ff6a5c08a9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Changelog: [Testing] [iOS] Use iPhone X in end to end tests since newer versions of iOS do not run on iPhone 6s
Reviewed By: TheSavior
Differential Revision: D18645860