Skip to content

Bump Xcode to 11.2.1#27434

Closed
hramos wants to merge 1 commit into
facebook:masterfrom
hramos:export-D18849584
Closed

Bump Xcode to 11.2.1#27434
hramos wants to merge 1 commit into
facebook:masterfrom
hramos:export-D18849584

Conversation

@hramos
Copy link
Copy Markdown
Contributor

@hramos hramos commented Dec 6, 2019

Summary:
Use Xcode 11 when testing iOS changes.

testNotUTF8Convertible disabled as NSString's -initWithBytes:length:encoding: segfaults on iOS 13.

Differential Revision: D18849584

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook labels Dec 6, 2019
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D18849584

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D18849584

Summary:
Pull Request resolved: facebook#27434
Pull Request resolved: facebook#27295

- Use latest Xcode version in both internal and external tests.
- Switch to iPhone 11 as target test simulator as it is included in a default Xcode 11 install.
- Update snapshot reference images to use iPhone 11 test device.
- `testNotUTF8Convertible` disabled as `NSString`'s `-initWithBytes:length:encoding:` currently segfaults on iOS 13.

Differential Revision: D18849584

fbshipit-source-id: 7e9eaf35f91ed5ec38814cf563ea1dc5f9b0d18c
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D18849584

@hramos hramos requested a review from cpojer as a code owner December 9, 2019 22:19
@pull-bot
Copy link
Copy Markdown

pull-bot commented Dec 9, 2019

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against be54e7f

@hramos hramos closed this Dec 12, 2019
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D18849584

hramos added a commit to hramos/react-native that referenced this pull request Jan 14, 2020
Summary:
Pull Request resolved: facebook#27434
Pull Request resolved: facebook#27295

- Use Xcode version 11.2.1 in both internal and external tests.
- Update snapshot reference images to use iPhone 8 test device.

Xcode 11.3.0 will be available in Sandcastle in the next week or so.

Changelog:

[Internal] - Bump Xcode version used in tests to 11.2.1.
[Internal] - Update iOS Snapshots.

Differential Revision: D18849584

fbshipit-source-id: 6efbd32c607702bb7291d462b71840bbef25def7
facebook-github-bot pushed a commit that referenced this pull request Jan 14, 2020
Summary:
Pull Request resolved: #27434
Pull Request resolved: #27295

- Use Xcode version 11.2.1 in both internal and external tests.
- Update snapshot reference images to use iPhone 8 test device.

Xcode 11.3.0 will be available in Sandcastle in the next week or so.

Changelog:

[Internal] - Bump Xcode version used in tests to 11.2.1.
[Internal] - Update iOS Snapshots.

Reviewed By: cs01

Differential Revision: D18849584

fbshipit-source-id: 9e3b92f080a4dc6a15dac0535b7562ff6a5c08a9
@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @hramos in 9fb2ca0.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jan 14, 2020
osdnk pushed a commit to osdnk/react-native that referenced this pull request Mar 9, 2020
Summary:
Pull Request resolved: facebook#27434
Pull Request resolved: facebook#27295

- Use Xcode version 11.2.1 in both internal and external tests.
- Update snapshot reference images to use iPhone 8 test device.

Xcode 11.3.0 will be available in Sandcastle in the next week or so.

Changelog:

[Internal] - Bump Xcode version used in tests to 11.2.1.
[Internal] - Update iOS Snapshots.

Reviewed By: cs01

Differential Revision: D18849584

fbshipit-source-id: 9e3b92f080a4dc6a15dac0535b7562ff6a5c08a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner RN Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants