Add in the optimization to check the first/least timer in the queue before iterating

[ejanzer]

Summary

Follow up from #27539 - adding back in the optimization that Detox has in TimersIdlingResource to avoid iterating over the entire timers queue if the next timer is already within the specified range.

Changelog

[Internal]

Test Plan

TimingModuleTest

Differential Revision: D19522346

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D19522346

[pull-bot]

Messages

📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message. Details CATEGORY may be: General iOS Android JavaScript Internal (for changes that do not need to be called out in the release notes) TYPE may be: Added, for new features. Changed, for changes in existing functionality. Deprecated, for soon-to-be removed features. Removed, for now removed features. Fixed, for any bug fixes. Security, in case of vulnerabilities. MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 0a514a8

[ejanzer]

cc @d4vidi

[d4vidi]

LGTM, except for maybe these concerns:

1. Some (very minimal) code duplication (timer "active" or not check)
2. Not sure what the policy here is but I'd add test coverage using unit tests

[ejanzer]

@d4vidi Agree about the repetition, I'll make a change. I did actually add unit tests for this function in the previous PR: https://github.com/facebook/react-native/blob/master/ReactAndroid/src/test/java/com/facebook/react/modules/timing/TimingModuleTest.java#L259

I haven't added any tests explicitly for this optimization, because that feels like an implementation detail that probably doesn't make sense to test (the functionality hasn't changed).

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D19522346

[react-native-bot]

This pull request was successfully merged by @ejanzer in 8f5779c.

^{When will my fix make it into a release? | Upcoming Releases}