Skip to content

Add in the optimization to check the first/least timer in the queue before iterating #27841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ejanzer wants to merge 1 commit into from
Closed

Add in the optimization to check the first/least timer in the queue before iterating #27841

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion ReactAndroid/src/main/java/com/facebook/react/modules/core/JavaTimerManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,12 +384,26 @@ public void run() {
*/
/* package */ boolean hasActiveTimersInRange(long rangeMs) {
synchronized (mTimerGuard) {
Timer nextTimer = mTimers.peek();
if (nextTimer == null) {
// Timers queue is empty
return false;
}
if (isTimerInRange(nextTimer, rangeMs)) {
// First check the next timer, so we can avoid iterating over the entire queue if it's
// already within range.
return true;
}
for (Timer timer : mTimers) {
if (!timer.mRepeat && timer.mInterval < rangeMs) {
if (isTimerInRange(timer, rangeMs)) {
return true;
}
}
}
return false;
}

private static boolean isTimerInRange(Timer timer, long rangeMs) {
return !timer.mRepeat && timer.mInterval < rangeMs;
}
}