Skip to content

Fix eslint-plugin README.md#29337

Closed
vpicone wants to merge 1 commit into
facebook:masterfrom
vpicone:patch-1
Closed

Fix eslint-plugin README.md#29337
vpicone wants to merge 1 commit into
facebook:masterfrom
vpicone:patch-1

Conversation

@vpicone
Copy link
Copy Markdown
Contributor

@vpicone vpicone commented Jul 10, 2020

Summary

The eslint-plugin package intent notice at the top of the README mistakenly refers to itself, it should instead refer to @react-native-community/eslint-config

Changelog

[Internal] [Fixed] - Fix typo in eslint-plugin README

Test Plan

  1. ensure link works properly

`eslint-plugin` package intent mistakenly refers to itself, should refer to `@react-native-community/eslint-config`
@vpicone vpicone requested review from cpojer and hramos as code owners July 10, 2020 18:19
@facebook-github-bot
Copy link
Copy Markdown
Contributor

Hi @vpicone!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@pull-bot
Copy link
Copy Markdown

Messages
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against b8a2277

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,760,779 0
android hermes armeabi-v7a 6,423,738 0
android hermes x86 7,148,430 0
android hermes x86_64 7,038,344 0
android jsc arm64-v8a 8,932,450 0
android jsc armeabi-v7a 8,587,804 0
android jsc x86 8,763,223 0
android jsc x86_64 9,338,773 0

Base commit: 120ff7c

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 10, 2020
@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 120ff7c

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

2 similar comments
@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Copy Markdown
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @vpicone in 4a97791.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants