Avoid Repo Structure Assumptions in RNTester Imports#30141
Closed
NickGerleman wants to merge 1 commit intofacebook:masterfrom
Closed
Avoid Repo Structure Assumptions in RNTester Imports#30141NickGerleman wants to merge 1 commit intofacebook:masterfrom
NickGerleman wants to merge 1 commit intofacebook:masterfrom
Conversation
RNTester has some imports left over that operate on directory traversal, assuming it is contained within react-native sources. This change makes these imports relative to react-native, enabling usage outside of the RN repo. Relates to microsoft/react-native-windows#6210 Validated we can bundle and flow-check for iOS + Android
facebook-github-bot
added
CLA Signed
Base commit: 7ebb71a |
Base commit: 7ebb71a |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@appden has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
kevkevinpal
approved these changes
Oct 13, 2020
Collaborator
|
This pull request was successfully merged by @NickGerleman in 4d247fe. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RNTester has some imports left over that operate on directory traversal, assuming it is contained within react-native sources. This change makes these imports relative to react-native, enabling usage outside of the RN repo.
Relates to microsoft/react-native-windows#6210
Changelog
[Internal] [Fixed] - Avoid File Structure Assumptions in RNTester Imports
Test Plan
Validated we can bundle and flow-check both iOS + Android