Pressability: fix typo in variable, follow event check pattern, small tweak#30151
Closed
Simek wants to merge 1 commit into
Closed
Pressability: fix typo in variable, follow event check pattern, small tweak#30151Simek wants to merge 1 commit into
Simek wants to merge 1 commit into
Conversation
Base commit: 3aa4de7 |
Base commit: 3aa4de7 |
kevkevinpal
reviewed
Oct 13, 2020
kevkevinpal
approved these changes
Oct 13, 2020
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@nadiia has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by @Simek in 7485208. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This small PR introduces the following changes to the
Pressability:isActivationTransitonvariable nameonPressMoveto variable before check and potential usage (this is the common pattern in this file)_touchActivatePositionChangelog
[Internal] [Fixed] - Pressability: fix typo in variable, follow event check pattern, small tweak
Test Plan
Successful
yarn testrun.