Skip to content

Add AbortController to eslint globals#30650

Closed
maltoze wants to merge 2 commits into
facebook:masterfrom
maltoze:master
Closed

Add AbortController to eslint globals#30650
maltoze wants to merge 2 commits into
facebook:masterfrom
maltoze:master

Conversation

@maltoze
Copy link
Copy Markdown
Contributor

@maltoze maltoze commented Dec 28, 2020

Summary

Fix eslint complaining about AbortController not being defined.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Hi @maltoze!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@pull-bot
Copy link
Copy Markdown

pull-bot commented Dec 28, 2020

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against f683cc46b004cb3eed7c17aeaf691b436f57dcde

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Dec 28, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 08eacf8

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 28, 2020
@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@dulmandakh dulmandakh requested a review from cpojer January 5, 2021 03:27
@dulmandakh
Copy link
Copy Markdown
Contributor

@maltoze could you please rebase so that CI errors are fixed, and run correctly.

@maltoze maltoze requested a review from hramos as a code owner January 5, 2021 21:56
This reverts commit fec6aee1816a996e2eca1a601e603b9acedf0cfe, reversing
changes made to 5454ff79f015281992f88f0e7c304a6989180f19.
@maltoze maltoze closed this Jan 5, 2021
@maltoze
Copy link
Copy Markdown
Contributor Author

maltoze commented Jan 5, 2021

@dulmandakh Sorry... I created a new one #30691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants