Skip to content

Add AbortController to eslint globals#30691

Closed
maltoze wants to merge 1 commit into
facebook:masterfrom
maltoze:fix/eslint-globals
Closed

Add AbortController to eslint globals#30691
maltoze wants to merge 1 commit into
facebook:masterfrom
maltoze:fix/eslint-globals

Conversation

@maltoze
Copy link
Copy Markdown
Contributor

@maltoze maltoze commented Jan 5, 2021

Summary

Fix eslint complaining about AbortController not being defined.

Changelog

Test Plan

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 5, 2021
@pull-bot
Copy link
Copy Markdown

pull-bot commented Jan 5, 2021

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 2d5c3d7

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 08eacf8

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,884,708 +0
android hermes armeabi-v7a 8,383,107 +0
android hermes x86 9,373,087 +0
android hermes x86_64 9,318,113 +0
android jsc arm64-v8a 10,340,065 +0
android jsc armeabi-v7a 9,821,550 +0
android jsc x86 10,389,929 +0
android jsc x86_64 10,975,234 +0

Base commit: 08eacf8

@dulmandakh dulmandakh requested review from cpojer and fkgozali January 6, 2021 01:43
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@mdvacca
Copy link
Copy Markdown
Contributor

mdvacca commented Jan 15, 2021

lgtm, importing to review and land

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@mdvacca merged this pull request in 2aab894.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants