chore: remove unused NativeDatePickerAndroid#32176
Closed
ecreeth wants to merge 1 commit into
Closed
Conversation
Base commit: 27dd2ec |
Base commit: 27dd2ec |
Contributor
|
@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
cortinico
approved these changes
Sep 9, 2021
Contributor
|
Hey @ecreeth Thanks for this PR but right now we are actively removing lean-core modules (schedule to be posted soon). This file backs native modules that we'll need to remove first internally and then we can remove the JS spec so this file was left here intentionally. For now, I will close this PR. Please let me know if you have any concerns, thanks again for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In 7a77052 the
DatePickerAndroidwas removed from the core but this file was forgotten.Changelog
[JavaScript][Removed] - remove unused
NativeDatePickerAndroidTest Plan
CI is green