Skip to content

chore: remove unused NativeDatePickerAndroid#32176

Closed
ecreeth wants to merge 1 commit into
facebook:mainfrom
ecreeth:remove-picker-android
Closed

chore: remove unused NativeDatePickerAndroid#32176
ecreeth wants to merge 1 commit into
facebook:mainfrom
ecreeth:remove-picker-android

Conversation

@ecreeth
Copy link
Copy Markdown
Contributor

@ecreeth ecreeth commented Sep 9, 2021

Summary

In 7a77052 theDatePickerAndroid was removed from the core but this file was forgotten.

Changelog

[JavaScript][Removed] - remove unused NativeDatePickerAndroid

Test Plan

CI is green

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2021
@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 27dd2ec

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,958,574 -758
android hermes armeabi-v7a 8,489,990 -721
android hermes x86 9,379,550 -582
android hermes x86_64 9,343,869 -749
android jsc arm64-v8a 10,640,621 -704
android jsc armeabi-v7a 9,559,566 -671
android jsc x86 10,655,886 -528
android jsc x86_64 11,263,898 -685

Base commit: 27dd2ec

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@lunaleaps
Copy link
Copy Markdown
Contributor

Hey @ecreeth

Thanks for this PR but right now we are actively removing lean-core modules (schedule to be posted soon). This file backs native modules that we'll need to remove first internally and then we can remove the JS spec so this file was left here intentionally.

For now, I will close this PR. Please let me know if you have any concerns, thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants