chore: Add comments explaining the existence of NativeDatePickerAndroid#33159
Closed
gabrieldonadel wants to merge 1 commit into
Closed
chore: Add comments explaining the existence of NativeDatePickerAndroid#33159gabrieldonadel wants to merge 1 commit into
gabrieldonadel wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
check #32176 (comment) |
Base commit: 3c958a8 |
Base commit: 3c958a8 |
Collaborator
Author
Ohhh got it, @lunaleaps is that still the case? And if so should we add some comment to that file to prevent other people from trying to delete it? |
Contributor
|
I believe so... yes a comment clarifying that would be helpful! |
gabrieldonadel
force-pushed
the
chore/remove-native-date-picker
branch
from
8341bfa to
27f6290
Compare
gabrieldonadel
changed the title
react-native-bot
added
the
Type: Enhancement
Collaborator
Author
Hi @lunaleaps, I've just added a comment to that file for clarification, please let me know if that text is ok or if I should change it for something else. Thanks! |
lunaleaps
approved these changes
Feb 25, 2022
Contributor
|
@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
|
This pull request was successfully merged by @gabrieldonadel in e139ef0. When will my fix make it into a release? | Upcoming Releases |
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
…id (facebook#33159) Summary: This PR adds comments explaining the reason why the `NativeDatePickerAndroid.js` file was kept when removing `DatePickerAndroid`(facebook@7a77052 ) in order to prevent people from trying to delete it, as this file has no references in the Github repo ## Changelog [Internal] [Added] - Add comments explaining the existence of NativeDatePickerAndroid Pull Request resolved: facebook#33159 Test Plan: Ensure builds are still working correctly, although this just adds a comment Reviewed By: cortinico Differential Revision: D34487638 Pulled By: lunaleaps fbshipit-source-id: 42cb7331e98d69ff2f69f19bfbb2e65c063120f7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comments explaining the reason why the
NativeDatePickerAndroid.jsfile was kept when removingDatePickerAndroid(7a77052 ) in order to prevent people from trying to delete it, as this file has no references in the Github repoChangelog
[Internal] [Added] - Add comments explaining the existence of NativeDatePickerAndroid
Test Plan
Ensure builds are still working correctly, although this just adds a comment