Fix broken Android CI due to broken BundleJsAndAssetsTask override#32194
Closed
cortinico wants to merge 1 commit into
Closed
Fix broken Android CI due to broken BundleJsAndAssetsTask override#32194cortinico wants to merge 1 commit into
BundleJsAndAssetsTask override#32194cortinico wants to merge 1 commit into
Conversation
Summary: This Diff fixes the `test_android` CircleCI that is currently broken due to a faulty `BundleJsAndAssetsTask` (that's my fault sorry for this). The CI is failing with a `execCommand == null!` error message. The message is happening as the aformentioned task is not correctly overriding `exec()` but just declaring a `TaskAction`. I'm fixing it. Changelog: [Internal] [Changed] - Fix broken Android CI due to broken `BundleJsAndAssetsTask` override Differential Revision: D30899742 fbshipit-source-id: ddfd35dea054f70596a7092b8bc9b8ba3ec2a3c5
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D30899742 |
|
Base commit: d4c347c |
Base commit: d4c347c |
Contributor
|
This pull request has been merged in 24bf1c5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This Diff fixes the
test_androidCircleCI that is currently broken due to a faultyBundleJsAndAssetsTask(that's my fault sorry for this).
The CI is failing with a
execCommand == null!error message. The message is happening as the aformentionedtask is not correctly overriding
exec()but just declaring aTaskAction. I'm fixing it.Changelog:
[Internal] [Changed] - Fix broken Android CI due to broken
BundleJsAndAssetsTaskoverrideDifferential Revision: D30899742