Skip to content

Fix broken Android CI due to broken BundleJsAndAssetsTask override #32194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cortinico wants to merge 1 commit into from
Closed

Fix broken Android CI due to broken BundleJsAndAssetsTask override #32194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions ...ct-native-gradle-plugin/src/main/kotlin/com/facebook/react/tasks/BundleJsAndAssetsTask.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ abstract class BundleJsAndAssetsTask : Exec() {
@get:OutputDirectory lateinit var jsSourceMapsDir: File
@get:OutputFile lateinit var jsSourceMapsFile: File

@TaskAction
fun run() {
override fun exec() {
cleanOutputDirectories()
executeBundleCommand()
configureBundleCommand()
super.exec()
}

private fun cleanOutputDirectories() {
Expand All @@ -47,7 +47,7 @@ abstract class BundleJsAndAssetsTask : Exec() {
jsSourceMapsDir.recreateDir()
}

private fun executeBundleCommand() {
private fun configureBundleCommand() {
workingDir(reactRoot)

@Suppress("SpreadOperator")
Expand All @@ -69,7 +69,5 @@ abstract class BundleJsAndAssetsTask : Exec() {
"--sourcemap-output",
jsSourceMapsFile,
*extraArgs.toTypedArray()))

super.exec()
}
}