Skip to content

feat: add getAll function to formdata#32444

Closed
matinzd wants to merge 1 commit into
facebook:mainfrom
matinzd:feat/add_getall_formdata
Closed

feat: add getAll function to formdata#32444
matinzd wants to merge 1 commit into
facebook:mainfrom
matinzd:feat/add_getall_formdata

Conversation

@matinzd
Copy link
Copy Markdown
Contributor

@matinzd matinzd commented Oct 20, 2021 •
edited
Loading

Summary

The getAll() method of the FormData interface returns all the values associated with a given key from within a FormData object.

Changelog

[General] [Added] - Add getAll function to FormData class for getting all parts containing that key. This is also available in web API.

Test Plan

New test added in FormData-test.js

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 20, 2021
@matinzd matinzd marked this pull request as ready for review October 20, 2021 12:06
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Oct 20, 2021
@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Oct 20, 2021
@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Oct 20, 2021 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 28064ee
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Oct 20, 2021

@SSHIC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@matinzd
Copy link
Copy Markdown
Contributor Author

matinzd commented Oct 22, 2021

@SSHIC any updates?

luluwu2032
luluwu2032 reviewed Mar 24, 2022
View reviewed changes
Comment thread Libraries/Network/__tests__/FormData-test.js Outdated
luluwu2032
luluwu2032 reviewed Mar 24, 2022
View reviewed changes
Comment thread Libraries/Network/FormData.js Outdated
@luluwu2032
Copy link
Copy Markdown
Contributor

luluwu2032 commented Mar 24, 2022

Also can you fix the failed checks @matinzd?

@matinzd matinzd force-pushed the feat/add_getall_formdata branch from 0c33daa to 1c21dd7 Compare March 24, 2022 16:02
@matinzd
Copy link
Copy Markdown
Contributor Author

matinzd commented Mar 24, 2022 •
edited
Loading

Also can you fix the failed checks @matinzd?

@SSHIC

Hey Lulu,
It seems that the first two tests have some problems on circle ci because they cannot build or install dependencies. I cannot fix them. It's also broken in main branch.

#33492

@matinzd matinzd changed the title feat: add getAll function to formdata polyfill feat: add getAll function to formdata Mar 24, 2022
@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Mar 24, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,985,652 +108
android hermes armeabi-v7a 7,359,958 +104
android hermes x86 8,321,711 +103
android hermes x86_64 8,290,661 +99
android jsc arm64-v8a 9,631,968 +53
android jsc armeabi-v7a 8,406,603 +44
android jsc x86 9,581,068 +52
android jsc x86_64 10,178,071 +57

Base commit: 28064ee
Branch: main

@cortinico
Copy link
Copy Markdown
Contributor

cortinico commented Mar 24, 2022

It seems that the first two tests have some problems on circle ci because they cannot build or install dependencies. I cannot fix them.

The two builds failures are unrelated and are currently broken on main. We're looking into them and can be disregarded here.

@matinzd
Copy link
Copy Markdown
Contributor Author

matinzd commented Mar 28, 2022

@cortinico Any update?

lunaleaps
lunaleaps approved these changes Mar 29, 2022
View reviewed changes
Comment thread Libraries/Network/__tests__/FormData-test.js Outdated
@cortinico
Copy link
Copy Markdown
Contributor

cortinico commented Mar 30, 2022

@matinzd those 2 failures were related to an Android issue that is now fixed on master. Don't you mind rebasing?

@matinzd matinzd force-pushed the feat/add_getall_formdata branch 5 times, most recently from e923254 to 766b627 Compare March 30, 2022 16:54
@matinzd
feat: add getAll function to formData
bdf429f 
The getAll() method of the FormData interface returns all the values associated with a given key from within a FormData object.

Reference: https://developer.mozilla.org/en-US/docs/Web/API/FormData
@matinzd matinzd force-pushed the feat/add_getall_formdata branch from 766b627 to bdf429f Compare March 30, 2022 16:56
@matinzd matinzd mentioned this pull request Mar 30, 2022
Merged
12 tasks
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 31, 2022

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

react-native-bot commented Mar 31, 2022

This pull request was successfully merged by @matinzd in d05a5d1.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Mar 31, 2022
@matinzd matinzd deleted the feat/add_getall_formdata branch April 2, 2022 16:21
@matinzd matinzd mentioned this pull request May 13, 2022
Open
typescript-bot pushed a commit to DefinitelyTyped/DefinitelyTyped that referenced this pull request Jun 26, 2022
@matinzd
🤖 Merge PR #59598 [react-native] feat: add getAll function type to fo…
0daf37a 
…rmData by @matinzd

* feat: add getAll function type to formData

Reference: facebook/react-native#32444

* tests: add getAll to tests

* tests: fix
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 15, 2023
@matinzd @Saadnajmi
feat: add getAll function to formdata (facebook#32444)
ba31649 
Summary:
The getAll() method of the [FormData](https://developer.mozilla.org/en-US/docs/Web/API/FormData) interface returns all the values associated with a given key from within a FormData object.

## Changelog

[General] [Added] - Add getAll function to FormData class for getting all parts containing that key. This is also available in web API.

Pull Request resolved: facebook#32444

Test Plan: New test added in FormData-test.js

Reviewed By: lunaleaps

Differential Revision: D31798633

Pulled By: cortinico

fbshipit-source-id: ef29bb54e930532a671adbe707be8d1a64ff0d82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunaleaps lunaleaps lunaleaps approved these changes

@hramos hramos Awaiting requested review from hramos

@yungsters yungsters Awaiting requested review from yungsters

@mhorowitz mhorowitz Awaiting requested review from mhorowitz

+1 more reviewer

@luluwu2032 luluwu2032 luluwu2032 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. Type: Enhancement A new feature or enhancement of an existing feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@matinzd @analysis-bot @facebook-github-bot @luluwu2032 @cortinico @react-native-bot @lunaleaps