Skip to content

Install dependencies for building HermesC on CircleCI (#33478)#33492

Closed
hramos wants to merge 1 commit into
facebook:mainfrom
hramos:export-D35131213
Closed

Install dependencies for building HermesC on CircleCI (#33478)#33492
hramos wants to merge 1 commit into
facebook:mainfrom
hramos:export-D35131213

Conversation

@hramos
Copy link
Copy Markdown
Contributor

@hramos hramos commented Mar 24, 2022

Summary:
Fixes silent failure when downloading Hermes tarball on Circle CI. Circle CI macOS hosts do not have wget, so we use curl instead.

Fixes subsequent failure due to HermesC not being built when Circle CI uses React Native from source -- since HermesC is only embedded in react-native npm releases -- by including the necessary cmake and ninja dependencies.

Creates new parametrized rntester job to verify that Hermes, built from source, succeeds.

Pull Request resolved: #33478

Changelog: [Internal]

Differential Revision: D35131213

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Mar 24, 2022
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 24, 2022

This pull request was exported from Phabricator. Differential Revision: D35131213

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 25, 2022

This pull request was exported from Phabricator. Differential Revision: D35131213

@hramos hramos force-pushed the export-D35131213 branch from a3aadd4 to b4bd494 Compare March 25, 2022 00:14
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 25, 2022

This pull request was exported from Phabricator. Differential Revision: D35131213

@hramos hramos force-pushed the export-D35131213 branch from b4bd494 to 89279c5 Compare March 25, 2022 01:14
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 25, 2022

This pull request was exported from Phabricator. Differential Revision: D35131213

@hramos hramos force-pushed the export-D35131213 branch from 89279c5 to 981a7b5 Compare March 25, 2022 02:21
@matinzd matinzd mentioned this pull request Mar 25, 2022
Closed
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 25, 2022

This pull request was exported from Phabricator. Differential Revision: D35131213

@hramos hramos force-pushed the export-D35131213 branch from 981a7b5 to 0122333 Compare March 25, 2022 21:43
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 25, 2022

This pull request was exported from Phabricator. Differential Revision: D35131213

@hramos hramos force-pushed the export-D35131213 branch from 0122333 to 32a91c2 Compare March 25, 2022 21:49
@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Mar 25, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: d2e8e7d
Branch: main

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Mar 25, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,979,033 -809
android hermes armeabi-v7a 7,353,171 +40
android hermes x86 8,315,316 -52
android hermes x86_64 8,284,442 +51
android jsc arm64-v8a 9,627,597 +0
android jsc armeabi-v7a 8,402,322 +0
android jsc x86 9,576,791 +0
android jsc x86_64 10,173,771 +0

Base commit: d31d83f
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 25, 2022

This pull request was exported from Phabricator. Differential Revision: D35131213

@hramos hramos force-pushed the export-D35131213 branch from 32a91c2 to 08a9b90 Compare March 25, 2022 23:39
@hramos hramos force-pushed the export-D35131213 branch from 08a9b90 to 6ffec73 Compare March 28, 2022 20:16
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 28, 2022

This pull request was exported from Phabricator. Differential Revision: D35131213

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 28, 2022

This pull request was exported from Phabricator. Differential Revision: D35131213

@hramos hramos force-pushed the export-D35131213 branch from 6ffec73 to 756490d Compare March 28, 2022 20:21
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 28, 2022

This pull request was exported from Phabricator. Differential Revision: D35131213

@hramos hramos force-pushed the export-D35131213 branch from 756490d to c235dc6 Compare March 28, 2022 20:33
@hramos hramos force-pushed the export-D35131213 branch from c235dc6 to 8cbefbf Compare March 28, 2022 20:40
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 28, 2022

This pull request was exported from Phabricator. Differential Revision: D35131213

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 29, 2022

This pull request was exported from Phabricator. Differential Revision: D35131213

@hramos hramos force-pushed the export-D35131213 branch from 8cbefbf to c5f21a9 Compare March 29, 2022 19:27
@hramos hramos force-pushed the export-D35131213 branch from c5f21a9 to 5340dae Compare March 29, 2022 21:00
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 29, 2022

This pull request was exported from Phabricator. Differential Revision: D35131213

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 29, 2022

This pull request was exported from Phabricator. Differential Revision: D35131213

@hramos hramos force-pushed the export-D35131213 branch from 5340dae to d919b78 Compare March 29, 2022 21:19
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 30, 2022

This pull request was exported from Phabricator. Differential Revision: D35131213

@hramos hramos force-pushed the export-D35131213 branch from d919b78 to 230fe23 Compare March 30, 2022 04:00
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 30, 2022

This pull request was exported from Phabricator. Differential Revision: D35131213

@hramos hramos force-pushed the export-D35131213 branch from 230fe23 to b05b0ca Compare March 30, 2022 04:42
@hramos @facebook-github-bot
Test Hermes built from source on Circle CI (facebook#33492)
f4e39d6 
Summary:
Pull Request resolved: facebook#33492

Fixes silent failure when downloading Hermes tarball on Circle CI. Circle CI macOS hosts do not have wget, so we use curl instead.

Fixes subsequent failure due to HermesC not being built when Circle CI uses React Native from source -- since HermesC is only embedded in react-native npm releases -- by making Hermes-from-source-jobs dependent on the same job that builds HermesC for releases.

Creates new parametrized rntester job to verify that Hermes, built from source, succeeds.

Changelog: [Internal]

Differential Revision: D35131213

fbshipit-source-id: 357183f411e862dc5a045ba4521d9675f34acffc
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 30, 2022

This pull request was exported from Phabricator. Differential Revision: D35131213

@hramos hramos force-pushed the export-D35131213 branch from b05b0ca to f4e39d6 Compare March 30, 2022 21:21
@cortinico
Copy link
Copy Markdown
Contributor

cortinico commented Apr 11, 2022

Closing as this was abandoned internally

@cortinico cortinico closed this Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hramos @facebook-github-bot @analysis-bot @cortinico