Make hermes-executor-common a static lib

[janicduplessis]

Summary

I've been seeing a couple crashes related to missing hermes-executor-common.so, seems to happen on specific android versions, but can't repro. I investigated this so file more and noticed it is incorrectly linked as a static library here

react-native/ReactAndroid/src/main/java/com/facebook/hermes/reactexecutor/Android.mk

Line 20 in b8f415e

LOCAL_STATIC_LIBRARIES := libjsireact libhermes-executor-common-release

. There doesn't seem to be any reason for this to be a shared lib so I changed it to be compiled as a static lib.

Changelog

[Android] [Fixed] - Make hermes-executor-common a static lib

Test Plan

• Verify there is no more hermes-executor-common-{release,debug}.so
• Test locally in an app to make sure it build and run properly.
• Verify that the crash happening on play store pre-launch report doesn't happen anymore.

[janicduplessis]

cc @ShikaSD @cortinico

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,445,722	+80,782
android	hermes	armeabi-v7a	7,754,787	+63,646
android	hermes	x86	8,910,885	+70,162
android	hermes	x86_64	8,856,165	+75,197
android	jsc	arm64-v8a	9,833,242	+153,383
android	jsc	armeabi-v7a	8,799,004	+131,449
android	jsc	x86	9,783,917	+147,949
android	jsc	x86_64	10,386,807	+153,814

Base commit: 79d20a1
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 79d20a1
Branch: main

[ShikaSD]

Hm, weird that it shows increase in size, I would expect the size actually decrease lol, or stay the same for jsc 🤔

[janicduplessis]

Yea that's weird, not sure if its an issue with the size calculation or there's actually a size change. Could be some cache that causes the old executor-common.so file to still be there but also the increased size of the executor.so file.

I did verify that the common.so file is no longer there after a clean build.

[janicduplessis]

I verified the size for my app and this causes a ~0.1mb size decrease according to the play store bundle explorer comparing versions before and after this change.

[cortinico]

Thanks for addressing this @janicduplessis

I investigated this so file more and noticed it is incorrectly linked as a static library here

According to the docs that should not be a problem as If the current module is a shared library or an executable, this variable will force these libraries to be linked into the resulting binary.

It's anyway good to fix those (and no size change should actually be reported).
I've also noticed that hermes-inspector is also affected by this. Don't you mind fixing it as well?

[facebook-github-bot]

@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @janicduplessis in b2cf24f.

^{When will my fix make it into a release? | Upcoming Releases}

[janicduplessis]

@cortinico Sure I can open a follow up pr to fix that other one soon.