Static link for hermes-inspector

[janicduplessis]

Summary

Follow up to #32683 to also link hermes-inspector statically.

Changelog

[Android] [Fix] - Static link for hermes-inspector

Test Plan

Tested a clean build and made sure hermes-inspector.so doesn't exist anymore.

[janicduplessis]

cc @cortinico

[pull-bot]

Messages

📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message. Details CATEGORY may be: General iOS Android JavaScript Internal (for changes that do not need to be called out in the release notes) TYPE may be: Added, for new features. Changed, for changes in existing functionality. Deprecated, for soon-to-be removed features. Removed, for now removed features. Fixed, for any bug fixes. Security, in case of vulnerabilities. MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 6046501

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 2bb91ae
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,290,597	+0
android	hermes	armeabi-v7a	7,621,606	+0
android	hermes	x86	8,761,192	+0
android	hermes	x86_64	8,700,633	+0
android	jsc	arm64-v8a	9,679,642	+0
android	jsc	armeabi-v7a	8,667,339	+0
android	jsc	x86	9,635,739	+0
android	jsc	x86_64	10,232,773	+0

Base commit: 2bb91ae
Branch: main

[facebook-github-bot]

@ShikaSD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[ShikaSD]

I believe removing it here is incorrect, as hermes-inspector is only used by debug flavour of executor

[janicduplessis]

From my understanding libhermes-inspector is linked into libhermes-executor-common-debug already (

react-native/ReactCommon/hermes/executor/Android.mk

Line 34 in 6046501

LOCAL_STATIC_LIBRARIES := libjsireact libhermes-inspector

) so it doesn't need to be included here. I checked the code quickly and it also doesn't seem to be using classes from libhermes-inspector directly (no <hermes/inspector/*> in ReactAndroid/src/main/java/com/facebook/hermes/reactexecutor).

[ShikaSD]

Ah, I see, makes sense :)

[react-native-bot]

This pull request was successfully merged by @janicduplessis in 20b0eba.

^{When will my fix make it into a release? | Upcoming Releases}