Move use_react_native_codegen_discovery to use_react_native!#32749
Closed
sota000 wants to merge 1 commit into
Closed
Move use_react_native_codegen_discovery to use_react_native!#32749sota000 wants to merge 1 commit into
sota000 wants to merge 1 commit into
Conversation
Summary: Changelog: [Internal] Move the use_react_native_codegen_discovery call to use_react_native. Found out that pre_install doesn't get invoked until all podspecs are read. This wouldn't work because I want use_react_native_codegen_discovery to generate React-Codgen podspecs. I also think it's better to have less logic in Podfiles as it's hard to update once users set it up. Reviewed By: cortinico Differential Revision: D33054318 fbshipit-source-id: 562f8ab5a10cd13abbaa55334ea109a2c296e814
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D33054318 |
Base commit: eb4ace8 |
Base commit: 4fb49cd |
Collaborator
|
This pull request was successfully merged by @sota000 in 24e07bc. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal] Move the use_react_native_codegen_discovery call to use_react_native.
Found out that pre_install doesn't get invoked until all podspecs are read. This wouldn't work because I want use_react_native_codegen_discovery to generate React-Codgen podspecs.
I also think it's better to have less logic in Podfiles as it's hard to update once users set it up.
Reviewed By: cortinico
Differential Revision: D33054318