Skip to content

Move use_react_native_codegen_discovery to use_react_native! #32749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sota000 wants to merge 1 commit into from
Closed

Move use_react_native_codegen_discovery to use_react_native! #32749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions packages/rn-tester/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,21 +26,18 @@ def pods(options = {})

prefix_path = "../.."

if options[:use_codegen_discovery]
Pod::UI.puts "[Codegen] Building target with codegen library discovery enabled."
pre_install do |installer|
use_react_native_codegen_discovery!({
react_native_path: prefix_path,
app_path: "#{Dir.pwd}",
fabric_enabled: fabric_enabled,
config_file_dir: "#{Dir.pwd}/node_modules",
})
end
if ENV['USE_CODEGEN_DISCOVERY'] == '1'
# Custom fabric component is only supported when using codegen discovery.
pod 'MyNativeView', :path => "NativeComponentExample"
end

use_react_native!(path: prefix_path, fabric_enabled: fabric_enabled, hermes_enabled: ENV['USE_HERMES'] == '1')
use_react_native!(
path: prefix_path,
fabric_enabled: fabric_enabled,
hermes_enabled: ENV['USE_HERMES'] == '1',
app_path: "#{Dir.pwd}",
config_file_dir: "#{Dir.pwd}/node_modules",
)
pod 'ReactCommon/turbomodule/samples', :path => "#{prefix_path}/ReactCommon"

# Additional Pods which aren't included in the default Podfile
Expand All @@ -53,7 +50,7 @@ def pods(options = {})
end

target 'RNTester' do
pods({ :use_codegen_discovery => ENV['USE_CODEGEN_DISCOVERY'] == '1' })
pods()
if !USE_FRAMEWORKS
use_flipper!
end
Expand Down
14 changes: 14 additions & 0 deletions scripts/react_native_pods.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,19 @@ def use_react_native! (options={})
pod 'boost', :podspec => "#{prefix}/third-party-podspecs/boost.podspec"
pod 'RCT-Folly', :podspec => "#{prefix}/third-party-podspecs/RCT-Folly.podspec"

if ENV['USE_CODEGEN_DISCOVERY'] == '1'
Pod::UI.puts "[Codegen] Building target with codegen library discovery enabled."
# TODO: Make sure this is run only once per execution.
app_path = options[:app_path]
config_file_dir = options[:config_file_dir]
use_react_native_codegen_discovery!({
react_native_path: prefix,
app_path: app_path,
fabric_enabled: fabric_enabled,
config_file_dir: config_file_dir,
})
end

# Generate a podspec file for generated files.
temp_podinfo = generate_temp_pod_spec_for_codegen!(fabric_enabled)
pod temp_podinfo['spec']['name'], :path => temp_podinfo['path']
Expand Down Expand Up @@ -354,6 +367,7 @@ def use_react_native_codegen_discovery!(options={})
Pod::UI.puts out;
else
Pod::UI.warn '[Codegen] error: no app_path was provided'
Pod::UI.warn '[Codegen] If you are calling use_react_native_codegen_discovery! in your Podfile, please remove the call and pass `app_path` and/or `config_file_dir` to `use_react_native!`.'
exit 1
end
end
Expand Down