Run Hermes CI benchmarks#33478
Closed
hramos wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35100459 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35100459 |
hramos
force-pushed
the
export-D35100459
branch
from
47dff9b to
fbd1ae3
Compare
Summary: Undoing the recent change that enabled Hermes to be built from source by default. Building Hermes from source now requires the use of the BUILD_HERMES_SOURCE envvar, again. To be re-enabled shortly. Pull Request resolved: facebook#33478 Changelog: [Internal] Differential Revision: D35100459 fbshipit-source-id: 5332f1a9f9aa331061d8b6e930a1fd0cf8a00c7e
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35100459 |
hramos
force-pushed
the
export-D35100459
branch
from
fbd1ae3 to
e0ba991
Compare
Collaborator
|
This pull request was successfully merged by @hramos in 8237ff2. When will my fix make it into a release? | Upcoming Releases |
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
Summary: Undoing the recent change that enabled Hermes to be built from source by default. Building Hermes from source now requires the use of the BUILD_HERMES_SOURCE envvar, again. To be re-enabled shortly. Pull Request resolved: facebook#33478 Changelog: [Internal] Reviewed By: cortinico Differential Revision: D35100459 fbshipit-source-id: ec83fcdf2432c689b0c02f86fbabcc8625975d51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D35100459