Fix tests for Windows#33893
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D36597593 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D36597593 |
cipolleschi
force-pushed
the
export-D36597593
branch
from
3ce6cc6 to
7345d26
Compare
Base commit: 406a474 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D36597593 |
cipolleschi
force-pushed
the
export-D36597593
branch
from
7345d26 to
bb03df7
Compare
Summary: Pull Request resolved: facebook#33893 The previous diff was breaking the external CI tests on Windows because of the file separators. The fix was to use UNIX separator but to apply `path.normalize` to make sure that the path is platform agnostic. ## Changelog [General][Fixed] - Make tests pass for windows Reviewed By: cortinico Differential Revision: D36597593 fbshipit-source-id: 10c5bc27d7b7ac211a18b38dd8ffa3591c085506
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D36597593 |
cipolleschi
force-pushed
the
export-D36597593
branch
from
bb03df7 to
49b2354
Compare
Collaborator
|
This pull request was successfully merged by @cipolleschi in 9596bf0. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The previous diff was breaking the external CI tests on Windows because of the file separators.
The fix was to use UNIX separator but to apply
path.normalizeto make sure that the path is platform agnostic.Changelog
[General][Fixed] - Make tests pass for windows
Differential Revision: D36597593