Skip to content

Fix tests for Windows #33893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cipolleschi wants to merge 1 commit into from
Closed

Fix tests for Windows #33893

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 32 additions & 30 deletions scripts/codegen/__tests__/generate-artifacts-executor-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ describe('delete empty files and folders', () => {
});

it("when path is folder and it's empty, removes it", () => {
const targetFolder = 'build/';
const targetFolder = 'build';
const content = [];

let statSyncInvocationCount = 0;
Expand Down Expand Up @@ -311,16 +311,18 @@ describe('delete empty files and folders', () => {
});

it("when path is folder and it's not empty, removes only empty folders and files", () => {
const targetFolder = 'build/';
const targetFolder = 'build';
const content = ['emptyFolder', 'emptyFile', 'notEmptyFile'];

const files = ['build/emptyFile', 'build/notEmptyFile'];
const files = [
path.normalize('build/emptyFile'),
path.normalize('build/notEmptyFile'),
];

const emptyContent = [];
const fileSizes = {
'build/emptyFile': 0,
'build/notEmptyFile': 32,
};
let fileSizes = {};
fileSizes[path.normalize('build/emptyFile')] = 0;
fileSizes[path.normalize('build/notEmptyFile')] = 32;

let statSyncInvocation = [];
let rmSyncInvocation = [];
Expand Down Expand Up @@ -352,23 +354,23 @@ describe('delete empty files and folders', () => {

underTest._cleanupEmptyFilesAndFolders(targetFolder);
expect(statSyncInvocation).toEqual([
'build/',
'build/emptyFolder',
'build/emptyFile',
'build/notEmptyFile',
path.normalize('build'),
path.normalize('build/emptyFolder'),
path.normalize('build/emptyFile'),
path.normalize('build/notEmptyFile'),
]);
expect(readdirInvocation).toEqual([
'build/',
'build/emptyFolder',
'build/emptyFolder',
'build/',
path.normalize('build'),
path.normalize('build/emptyFolder'),
path.normalize('build/emptyFolder'),
path.normalize('build'),
]);
expect(rmSyncInvocation).toEqual(['build/emptyFile']);
expect(rmdirSyncInvocation).toEqual(['build/emptyFolder']);
expect(rmSyncInvocation).toEqual([path.normalize('build/emptyFile')]);
expect(rmdirSyncInvocation).toEqual([path.normalize('build/emptyFolder')]);
});

it('when path is folder and it contains only empty folders, removes everything', () => {
const targetFolder = 'build/';
const targetFolder = 'build';
const content = ['emptyFolder1', 'emptyFolder2'];
const emptyContent = [];

Expand Down Expand Up @@ -406,23 +408,23 @@ describe('delete empty files and folders', () => {

underTest._cleanupEmptyFilesAndFolders(targetFolder);
expect(statSyncInvocation).toEqual([
'build/',
'build/emptyFolder1',
'build/emptyFolder2',
path.normalize('build'),
path.normalize('build/emptyFolder1'),
path.normalize('build/emptyFolder2'),
]);
expect(readdirInvocation).toEqual([
'build/',
'build/emptyFolder1',
'build/emptyFolder1',
'build/emptyFolder2',
'build/emptyFolder2',
'build/',
path.normalize('build'),
path.normalize('build/emptyFolder1'),
path.normalize('build/emptyFolder1'),
path.normalize('build/emptyFolder2'),
path.normalize('build/emptyFolder2'),
path.normalize('build'),
]);
expect(rmSyncInvocation).toEqual([]);
expect(rmdirSyncInvocation).toEqual([
'build/emptyFolder1',
'build/emptyFolder2',
'build/',
path.normalize('build/emptyFolder1'),
path.normalize('build/emptyFolder2'),
path.normalize('build'),
]);
});
});