Skip to content

fix: switch deprecated babel-eslint for @babel/eslint-parser#33949

Closed
BeeMargarida wants to merge 1 commit into
facebook:mainfrom
BeeMargarida:packages/change-babel-eslint
Closed

fix: switch deprecated babel-eslint for @babel/eslint-parser#33949
BeeMargarida wants to merge 1 commit into
facebook:mainfrom
BeeMargarida:packages/change-babel-eslint

Conversation

@BeeMargarida
Copy link
Copy Markdown
Contributor

Summary

Related to this comment and its response, the package babel-eslint was deprecated and was moved to @babel/eslint-parser.

Changelog

[General] [Changed] - Switch deprecated dependency babel-eslint for @babel/eslint-parser

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jun 1, 2022
@cortinico
Copy link
Copy Markdown
Contributor

Let me know if you need furhter support here @BeeMargarida 👍

@BeeMargarida
Copy link
Copy Markdown
Contributor Author

BeeMargarida commented Jun 1, 2022

Let me know if you need furhter support here @BeeMargarida 👍

Thank you 🙏 The CI is failing, I'm a bit lost about the way to fix it. If I change all usages of babel-eslint to @babel/eslint-parser, and run yarn lint, it throws out errors like the ones below.

Parsing error: This experimental syntax requires enabling one of the following parser plugin(s): "jsx", "flow", "typescript".

Parsing error: Unexpected token, expected "from"

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,788,160 +0
android hermes armeabi-v7a 7,191,742 +0
android hermes x86 8,099,524 +0
android hermes x86_64 8,077,021 +0
android jsc arm64-v8a 9,656,265 +0
android jsc armeabi-v7a 8,428,768 +0
android jsc x86 9,608,435 +0
android jsc x86_64 10,202,993 +0

Base commit: 55a1cfe
Branch: main

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 92ebb29
Branch: main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants