fix(eslint-config): switch to new babel parser

[Kerumen]

Summary

babel-eslint is deprecated now. We should use the new Babel parser.

Changelog

[General] [Fixed] - Use new Babel parser instead of deprecated one

Test Plan

Ensure lint is working as expected.

[facebook-github-bot]

@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,824,049	+31
android	hermes	armeabi-v7a	7,211,097	+37
android	hermes	x86	8,134,514	+30
android	hermes	x86_64	8,114,560	+33
android	jsc	arm64-v8a	9,690,968	+21
android	jsc	armeabi-v7a	8,446,911	+22
android	jsc	x86	9,642,197	+26
android	jsc	x86_64	10,239,256	+22

Base commit: ea29ae1
Branch: main

[cortinico]

Thanks for sending this over @Kerumen

This is sadly not sufficient. Please check another other similar attempt here:

• fix: switch deprecated babel-eslint for @babel/eslint-parser #33949

We need to update all the references of babel-eslint in the codebase

[Kerumen]

@cortinico I don't see a lot of reference. Maybe I should also update the test here?

[cortinico]

@cortinico I don't see a lot of reference. Maybe I should also update the test here?

A quick grep returns this:

rg "babel-eslint"
CHANGELOG.md
2835:- Upgrade babel-eslint to 9.0.0 ([44dc283bcd](https://github.com/facebook/react-native/commit/44dc283bcd0a75826d9be86cdc727e32d5697ef2) by [@rafeca](https://github.com/rafeca))
2966:- Upgrade babel-eslint to v9.0.0-beta.2 with better support for Flow ([abf1188de2](https://github.com/facebook/react-native/commit/abf1188de225e4b7d36ecbad316af92ca29c85c2) by [@rubennorte](https://github.com/rubennorte))

yarn.lock
1780:babel-eslint@^10.1.0:
1782:  resolved "https://registry.yarnpkg.com/babel-eslint/-/babel-eslint-10.1.0.tgz#6968e568a910b78fb3779cdd8b6ac2f479943232"

repo-config/package.json
19:    "babel-eslint": "^10.1.0",

packages/eslint-config-react-native-community/yarn.lock
403:babel-eslint@^10.1.0:
405:  resolved "https://registry.yarnpkg.com/babel-eslint/-/babel-eslint-10.1.0.tgz#6968e568a910b78fb3779cdd8b6ac2f479943232"

packages/eslint-config-react-native-community/package.json
17:    "babel-eslint": "^10.1.0",

packages/eslint-config-react-native-community/index.js
39:      parser: 'babel-eslint',

packages/eslint-plugin-react-native-community/__tests__/eslint-tester.js
15:  parser: require.resolve('babel-eslint'),

packages/eslint-plugin-specs/__tests__/eslint-tester.js
15:  parser: require.resolve('babel-eslint'),

[Kerumen]

The only important one here are repo-config/package.json and packages/eslint-plugin-specs. Should I update them? I don't know what repo-config is doing.

[cortinico]

Should I update them? I don't know what repo-config is doing.

Yeah the should all be updated.

repo-config is the yarn workspace for the whole repository

[Kerumen]

@cortinico Done! ✅

[cortinico]

@cortinico Done! ✅

Great 👍 The problem is that now we need to make the CI green

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: ea29ae1
Branch: main

[Kerumen]

The CI is green now! 🟢

Here is what I did:

• I added requireConfigFile: false as it's needed since Babel v11
• I added @babel/preset-flow for eslint-plugin-specs as it tests Flow code with some Flow syntax
• I added missing @babel/core in eslint-config

[cortinico]

The CI is green now! 🟢

Here is what I did:

• I added requireConfigFile: false as it's needed since Babel v11
• I added @babel/preset-flow for eslint-plugin-specs as it tests Flow code with some Flow syntax
• I added missing @babel/core in eslint-config

Awesome stuff! We'll re-import this and we should be fine merging it 👍

[facebook-github-bot]

@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[ghost]

Any progress here? 🚀

[cortinico]

Any progress here? 🚀

Sadly not. I've been trying to merge this PR internally, but our setup related to babel is quite intricate and it's more challenging than expected.

[react-native-bot]

This pull request was successfully merged by @Kerumen in 97291bf.

^{When will my fix make it into a release? | Upcoming Releases}

[cortinico]

Kudos to @jacdebug for unblocking this 👍