Fix HERMES_ENABLED check in scripts/react-native-xcode.sh#34675
Fix HERMES_ENABLED check in scripts/react-native-xcode.sh#34675nvojnovic wants to merge 1 commit into
Conversation
|
Hi @nvojnovic! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @nvojnovic in 8745a14. When will my fix make it into a release? | Upcoming Releases |
Summary
Checking if Hermes is enabled is failing because there is no
podfile.lockfile in the directory where this script is executed andUSE_HERMESwill be set tofalsewhich will prevent building Hermes binary jsbundle.Changelog
[iOS] [Fixed] -
HERMES_ENABLEDcheck fixed in react-native-xcode.shTest Plan
main.jsbundlefile is Hermes binary bundle