Skip to content

Fix HERMES_ENABLED in react-native-xcode.sh#34728

Closed
janicduplessis wants to merge 1 commit into
facebook:mainfrom
janicduplessis:fix-hermes-enabled
Closed

Fix HERMES_ENABLED in react-native-xcode.sh#34728
janicduplessis wants to merge 1 commit into
facebook:mainfrom
janicduplessis:fix-hermes-enabled

Conversation

@janicduplessis
Copy link
Copy Markdown
Contributor

@janicduplessis janicduplessis commented Sep 20, 2022

Summary

HERMES_ENABLED value is currently wrong when running in a normal project setup. When running grep the current directory is the project root directory, which is not where the Podfile.lock usually is ("$rootProject/ios"). To make sure to grep the right folder we can use the PODS_PODFILE_DIR_PATH env provided by Cocoapods.

Changelog

[General] [Fixed] - Fix HERMES_ENABLED in react-native-xcode.sh

Test Plan

Verify that hermes cli runs properly in a project with hermes enabled.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 20, 2022
@facebook-github-bot facebook-github-bot added Contributor A React Native contributor. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 20, 2022
@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,694,463 -21
android hermes armeabi-v7a 7,098,006 -10
android hermes x86 7,997,194 -34
android hermes x86_64 7,969,697 -42
android jsc arm64-v8a 9,565,058 +66
android jsc armeabi-v7a 8,332,032 +55
android jsc x86 9,505,473 +61
android jsc x86_64 10,097,084 +31

Base commit: 010da67
Branch: main

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 353b1b0
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cortinico
Copy link
Copy Markdown
Contributor

cortinico commented Sep 20, 2022

This looks like a duplicate of #34675 right?

@janicduplessis
Copy link
Copy Markdown
Contributor Author

It is, I didn’t see #34675. Funny that we have the exact same fix including the file capitalization change 😅

@janicduplessis
Copy link
Copy Markdown
Contributor Author

#34675 landed so this is not needed

@janicduplessis janicduplessis deleted the fix-hermes-enabled branch September 21, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants