chore: Extract codegen ModuleInterfaceNotFoundParserError in a separate function#34922
Closed
gabrieldonadel wants to merge 2 commits into
Closed
chore: Extract codegen ModuleInterfaceNotFoundParserError in a separate function#34922gabrieldonadel wants to merge 2 commits into
gabrieldonadel wants to merge 2 commits into
Conversation
facebook-github-bot
added
the
CLA Signed
cipolleschi
requested changes
Oct 10, 2022
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Amazing, thank you so much.
Can you update the test file? 🙏
Base commit: 38fcafe |
Base commit: 38fcafe |
cipolleschi
approved these changes
Oct 10, 2022
gabrieldonadel
force-pushed
the
chore/extract-interface-not-found-error
branch
from
5d8f8ea to
04cb6b0
Compare
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
|
This pull request was successfully merged by @gabrieldonadel in c9338c4. When will my fix make it into a release? | Upcoming Releases |
mohitcharkha
pushed a commit
to mohitcharkha/react-native
that referenced
this pull request
Oct 17, 2022
…te function (facebook#34922) Summary: This PR extracts the codegen `ModuleInterfaceNotFoundParserError` exception into a separate function inside `error-utils.js` so that it can be used by both Flow and Typescript parsers as requested on facebook#34872. This also adds unit tests to the new `throwIfModuleInterfaceNotFound` function. [Internal] [Changed] - Extract codegen `ModuleInterfaceNotFoundParserError` in a separate function that can de used by Flow and TypeScript parsers Pull Request resolved: facebook#34922 Test Plan: Run `yarn jest react-native-codegen` and ensure CI is green  Reviewed By: dmytrorykun Differential Revision: D40296533 Pulled By: cipolleschi fbshipit-source-id: 205469b15337f6c3847936a6ef5427b5a9e08665
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extracts the codegen
ModuleInterfaceNotFoundParserErrorexception into a separate function insideerror-utils.jsso that it can be used by both Flow and Typescript parsers as requested on #34872. This also adds unit tests to the newthrowIfModuleInterfaceNotFoundfunction.Changelog
[Internal] [Changed] - Extract codegen
ModuleInterfaceNotFoundParserErrorin a separate function that can de used by Flow and TypeScript parsersTest Plan
Run
yarn jest react-native-codegenand ensure CI is green