-
Notifications
You must be signed in to change notification settings - Fork 25.2k
chore: Extract codegen ModuleInterfaceNotFoundParserError in a separate function #34922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
gabrieldonadel
wants to merge
2
commits into
facebook:main
from
gabrieldonadel:chore/extract-interface-not-found-error
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
37 changes: 37 additions & 0 deletions
37
packages/react-native-codegen/src/parsers/__tests__/error-utils-test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| /** | ||
| * Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| * | ||
| * @format | ||
| * @flow strict-local | ||
| * @oncall react_native | ||
| */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| const {throwIfModuleInterfaceNotFound} = require('../error-utils'); | ||
| const {ModuleInterfaceNotFoundParserError} = require('../errors'); | ||
|
|
||
| describe('throwIfModuleInterfaceNotFound', () => { | ||
| it('throw error if there are zero module specs', () => { | ||
| const nativeModuleName = 'moduleName'; | ||
| const specId = {name: 'Name'}; | ||
| const parserType = 'TypeScript'; | ||
|
|
||
| expect(() => { | ||
| throwIfModuleInterfaceNotFound(0, nativeModuleName, specId, parserType); | ||
| }).toThrow(ModuleInterfaceNotFoundParserError); | ||
| }); | ||
|
|
||
| it("don't throw error if there is at least one module spec", () => { | ||
| const nativeModuleName = 'moduleName'; | ||
| const specId = {name: 'Spec'}; | ||
| const parserType = 'Flow'; | ||
|
|
||
| expect(() => { | ||
| throwIfModuleInterfaceNotFound(1, nativeModuleName, specId, parserType); | ||
| }).not.toThrow(ModuleInterfaceNotFoundParserError); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| /** | ||
| * Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| * | ||
| * @flow strict-local | ||
| * @format | ||
| */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| import type {ParserType} from './errors'; | ||
| const {ModuleInterfaceNotFoundParserError} = require('./errors.js'); | ||
|
|
||
| function throwIfModuleInterfaceNotFound( | ||
| numberOfModuleSpecs: number, | ||
| nativeModuleName: string, | ||
| ast: $FlowFixMe, | ||
| parserType: ParserType, | ||
| ) { | ||
| if (numberOfModuleSpecs === 0) { | ||
| throw new ModuleInterfaceNotFoundParserError( | ||
| nativeModuleName, | ||
| ast, | ||
| parserType, | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| module.exports = { | ||
| throwIfModuleInterfaceNotFound, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.