Skip to content

chore: Export codegen parseFile function#35000

Closed
gabrieldonadel wants to merge 1 commit into
facebook:mainfrom
gabrieldonadel:chore/export-parse-file
Closed

chore: Export codegen parseFile function#35000
gabrieldonadel wants to merge 1 commit into
facebook:mainfrom
gabrieldonadel:chore/export-parse-file

Conversation

@gabrieldonadel
Copy link
Copy Markdown
Collaborator

Summary

This PR export the content of the parseFile into a parseFile function accepting a callback to buildSchema properly in parsers/utils.js as requested on #34872.

Changelog

[Internal] [Changed] - Export parseFile in to a parseFile function in parsers/utils.js

Test Plan

Run yarn jest react-native-codegen and ensure CI is green

image

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 16, 2022
@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Oct 16, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: f6cfcc3
Branch: main

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Oct 16, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,779,049 +0
android hermes armeabi-v7a 7,182,722 -2
android hermes x86 8,093,708 -6
android hermes x86_64 8,065,250 -4
android jsc arm64-v8a 9,637,564 +0
android jsc armeabi-v7a 8,403,155 +0
android jsc x86 9,587,498 +0
android jsc x86_64 10,181,042 +0

Base commit: f6cfcc3
Branch: main

Copy link
Copy Markdown
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. It looks good to me! :D

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@gabrieldonadel gabrieldonadel force-pushed the chore/export-parse-file branch from b707842 to b2a1e52 Compare October 17, 2022 12:17
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@gabrieldonadel
Copy link
Copy Markdown
Collaborator Author

@cipolleschi would you mind checking what the Facebook Internal Linter is complaining about for me?

@gabrieldonadel gabrieldonadel force-pushed the chore/export-parse-file branch from 8db3d79 to bf97fd8 Compare October 18, 2022 15:40
@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @gabrieldonadel in 376ffac.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 19, 2022
@gabrieldonadel gabrieldonadel deleted the chore/export-parse-file branch October 19, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. hacktoberfest-accepted Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants