feat(ios): Share with anchor#35008
Conversation
Base commit: a0ee6fa |
Base commit: 0481948 |
|
hey @zhumingcheng697 thank you for your PR! there are a couple CI tests failing, could you please take a look? |
|
Hi @skinsshark, the analyze_code test seems to be a dependency issue where TypeScript complains that some internal modules and/or type declarations cannot be found. The other test_windows one failed rather curiously in a test case for I can’t figure out how my changes could have led to the failing tests. Besides, these two tests also seem to be affecting other PRs like #35000 or even latest pushes on the main branch like 0481948. |
|
@skinsshark has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
i fixed the errors called out from the analyze_code test and will rebase your PR on top and land both- thanks! |
|
This pull request was successfully merged by @zhumingcheng697 in aeab383. When will my fix make it into a release? | Upcoming Releases |
Summary
Sharecurrently does not support theanchoroption in iOS, so share sheets will always be displayed in the middle of the screen on iPads and on the top left corner of the window on Mac Catalyst.This PR utilizes the
anchorfunctionality already implemented inActionSheetIOSto bring this support toShareon iOS.Changelog
[iOS] [Changed] - type definition for the
optionsparameter ofShare.share(added optionalanchorproperty)[iOS] [Added] -
anchoroption support forShareTest Plan
Tested with modified
rn-testerthat utilizes theanchoroption on iPad simulator. Marked all 3 changes in code.