Back out "add oncall annotation for BUCK files in xplat based on supermodule information - /home/s2shi/tmp/xplat_buck_oncall/xplat_buck_2nd_batch00" (#35064)#35065
Closed
cipolleschi wants to merge 2 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D40637084 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D40637084 |
cipolleschi
force-pushed
the
export-D40637084
branch
from
8cafe7f to
c45d2c4
Compare
…rmodule information - /home/s2shi/tmp/xplat_buck_oncall/xplat_buck_batch10" Summary: Original commit changeset: 0fb0db845c04 Original Phabricator Diff: D40610875 (facebook@d941940) Differential Revision: D40635873 fbshipit-source-id: d0beb349aebeed5113d8914feff6d4c093cfe9ed
…rmodule information - /home/s2shi/tmp/xplat_buck_oncall/xplat_buck_2nd_batch00" (facebook#35065) Summary: Pull Request resolved: facebook#35065 Original commit changeset: ac76ea701e3d Original Phabricator Diff: D40611860 (facebook@860b4d9) Open source is using BUCK 1 which does not seem to have the `oncall` directive. Backing it out because it is breaking the external CI. ## Changelog [internal] Reviewed By: cortinico Differential Revision: D40637084 fbshipit-source-id: be1dd076d74432a087e5f685c2c5c7a0738991b9
cipolleschi
force-pushed
the
export-D40637084
branch
from
c45d2c4 to
caf2283
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D40637084 |
Base commit: 9a87db2 |
|
PR build artifact for caf2283 is ready. |
|
PR build artifact for caf2283 is ready. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in c638822. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Pull Request resolved: #35064
Original commit changeset: 0fb0db845c04
Original Phabricator Diff: D40610875 (d941940)
Open source is using BUCK 1 which does not seem to have the
oncalldirective.Backing it out because it is breaking the external CI.
Changelog
[internal]
Reviewed By: cortinico
Differential Revision: D40637084