Skip to content

Back out "add oncall annotation for BUCK files in xplat based on supermodule information - /home/s2shi/tmp/xplat_buck_oncall/xplat_buck_2nd_batch00" (#35064) #35065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cipolleschi wants to merge 2 commits into from
Closed

Back out "add oncall annotation for BUCK files in xplat based on supermodule information - /home/s2shi/tmp/xplat_buck_oncall/xplat_buck_2nd_batch00" (#35064) #35065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8b73ef
Back out "add oncall annotation for BUCK files in xplat based on supe…
Oct 24, 2022
caf2283
Back out "add oncall annotation for BUCK files in xplat based on supe…
cipolleschi Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions IntegrationTests/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ load("@fbsource//tools/build_defs/oss:metro_defs.bzl", "rn_library")
# This file was generated by running
# js1 build buckfiles

oncall("react_native")

rn_library(
name = "IntegrationTests",
srcs = js_library_glob(
Expand Down
2 changes: 0 additions & 2 deletions Libraries/FBLazyVector/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "fb_apple_library")

oncall("react_native")

fb_apple_library(
name = "FBLazyVector",
exported_headers = [
Expand Down
2 changes: 0 additions & 2 deletions Libraries/RCTRequired/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "fb_apple_library")

oncall("react_native")

fb_apple_library(
name = "RCTRequired",
exported_headers = [
Expand Down
2 changes: 0 additions & 2 deletions React/CoreModules/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ load(
"react_module_plugin_providers",
)

oncall("react_native")

rn_apple_library(
name = "CoreModulesApple",
srcs = glob(
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/androidTest/java/com/facebook/react/testing/network/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "network",
srcs = glob(["**/*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/androidTest/js/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ load("//tools/build_defs/oss:metro_defs.bzl", "rn_library")
# This file was generated by running
# js1 build buckfiles

oncall("react_native")

rn_library(
name = "js",
srcs = js_library_glob(
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/debug/holder/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "holder",
srcs = glob(["*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/debug/tags/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "tags",
srcs = glob(["*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/hermes/instrumentation/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "instrumentation",
srcs = ["HermesMemoryDumper.java"],
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "react",
srcs = glob(["*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/animated/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "animated",
srcs = glob([
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/bridge/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "IS_OSS_BUILD", "react_native_dep", "react_native_target", "react_native_tests_target", "rn_android_library")

oncall("react_native")

INTERFACES = [
"Dynamic.java",
"ReadableMap.java",
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/common/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "HERMES_BYTECODE_VERSION", "react_native_dep", "rn_android_build_config", "rn_android_library")

oncall("react_native")

SUB_PROJECTS = [
"network/**/*",
"mapbuffer/**/*",
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/common/mapbuffer/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "FBJNI_TARGET", "react_native_dep", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "mapbuffer",
srcs = glob([
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/common/network/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "network",
srcs = glob(["**/*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/config/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "config",
srcs = glob(["**/*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/devsupport/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "devsupport",
srcs = glob(["*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/fabric/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "IS_OSS_BUILD", "YOGA_TARGET", "react_native_android_toplevel_dep", "react_native_dep", "react_native_target", "rn_android_library")

oncall("react_native")

# TODO(T115916830): Remove when Kotlin files are used in this module
KOTLIN_STDLIB_DEPS = [react_native_android_toplevel_dep("third-party/kotlin:kotlin-stdlib")] if IS_OSS_BUILD else []

Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/jscexecutor/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "jscexecutor",
srcs = glob(["*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/jstasks/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "jstasks",
srcs = glob(["*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/module/annotations/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "annotations",
srcs = glob(["**/*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/module/model/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "model",
srcs = glob(["**/*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/module/processing/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_target", "rn_java_annotation_processor", "rn_java_library")

oncall("react_native")

rn_java_annotation_processor(
name = "processing",
does_not_affect_abi = True,
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/modules/accessibilityinfo/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "accessibilityinfo",
srcs = glob(["**/*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/modules/appearance/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "appearance",
srcs = glob(["**/*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/modules/appregistry/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "appregistry",
srcs = glob(["**/*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/modules/appstate/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "appstate",
srcs = glob(["**/*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/modules/blob/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "blob",
srcs = glob(["**/*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/modules/bundleloader/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "bundleloader",
srcs = glob(["*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/modules/camera/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "camera",
srcs = glob(["**/*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/modules/clipboard/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "clipboard",
srcs = glob(["**/*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/modules/common/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "common",
srcs = glob(["**/*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/modules/core/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "core",
srcs = glob(["**/*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/modules/debug/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "debug",
srcs = glob(["*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/modules/deviceinfo/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "deviceinfo",
srcs = glob(["**/*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/modules/dialog/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "dialog",
srcs = glob(["**/*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/modules/fabric/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "fabric",
srcs = glob(["**/*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/modules/fresco/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "fresco",
srcs = glob(["**/*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/modules/i18nmanager/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "i18nmanager",
srcs = glob(["*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/modules/image/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "image",
srcs = glob(["*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/modules/intent/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "intent",
srcs = glob(["**/*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/modules/network/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "network",
srcs = glob(["**/*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/modules/permissions/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "permissions",
srcs = glob(["**/*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/modules/share/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "share",
srcs = glob(["**/*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/modules/sound/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "sound",
srcs = glob(["**/*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/modules/statusbar/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "statusbar",
srcs = glob(["**/*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/modules/storage/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "storage",
srcs = glob(["**/*.java"]),
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "systeminfo",
srcs = [
Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/modules/toast/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library")

oncall("react_native")

rn_android_library(
name = "toast",
srcs = glob(["**/*.java"]),
Expand Down
Loading