Skip to content

Adding Dev Loading controller without activity for VR#35392

Closed
arushikesarwani94 wants to merge 1 commit into
facebook:mainfrom
arushikesarwani94:export-D40947239
Closed

Adding Dev Loading controller without activity for VR#35392
arushikesarwani94 wants to merge 1 commit into
facebook:mainfrom
arushikesarwani94:export-D40947239

Conversation

@arushikesarwani94
Copy link
Copy Markdown
Contributor

@arushikesarwani94 arushikesarwani94 commented Nov 18, 2022

Summary:
Changelog:
[General][Added] - For supporting Dev Loading View across platforms, adding the DevLoadingViewController without an activity/context.

Differential Revision: D40947239

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Nov 18, 2022
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Nov 18, 2022

This pull request was exported from Phabricator. Differential Revision: D40947239

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Nov 18, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,102,558 +118
android hermes armeabi-v7a 6,470,621 +128
android hermes x86 7,520,011 +116
android hermes x86_64 7,378,685 +112
android jsc arm64-v8a 8,967,210 -99
android jsc armeabi-v7a 7,698,059 -93
android jsc x86 9,029,323 -95
android jsc x86_64 9,507,162 -101

Base commit: 850f855
Branch: main

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Nov 18, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: d9ade19
Branch: main

@pull-bot
Copy link
Copy Markdown

pull-bot commented Nov 18, 2022

PR build artifact for a74781a4ef166ec778ffab2f9c8cd414cc13aaf3 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link
Copy Markdown

pull-bot commented Nov 18, 2022

PR build artifact for a74781a4ef166ec778ffab2f9c8cd414cc13aaf3 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@arushikesarwani94 @facebook-github-bot
Adding Dev Loading controller without activity for VR (facebook#35392)
020ec7b 
Summary:
Pull Request resolved: facebook#35392

Changelog:
    [General][Added] - For supporting Dev Loading View across platforms, adding the DevLoadingViewController without an activity/context.

Reviewed By: rshest

Differential Revision: D40947239

fbshipit-source-id: fcc524b33d9df174cd0d11ae6c1a00a04f3042bc
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Nov 21, 2022

This pull request was exported from Phabricator. Differential Revision: D40947239

@pull-bot
Copy link
Copy Markdown

pull-bot commented Nov 21, 2022

PR build artifact for 020ec7b is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link
Copy Markdown

pull-bot commented Nov 21, 2022

PR build artifact for 020ec7b is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arushikesarwani94 @facebook-github-bot @analysis-bot @pull-bot