fix: remove old command for align packages versions#38548
Closed
kelset wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
facebook-github-bot
added
the
Shared with Meta
cortinico
approved these changes
Jul 21, 2023
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
I guess I've just changed my mind between merging it into Make sure removing this section in docs, if you end up removing this command. |
hoxyq
referenced
this pull request
Jul 21, 2023
…script (#36568) Summary: Pull Request resolved: #36568 Changelog: [Internal] Okay, so before the monorepo migration we had to use two scripts separately: 1. Bumping every package with `npm run bump-all-updated-packages` 2. Aligning other packages versions with `npm run align-package-versions` The reason for it is that *before the monorepo* in a release branch cutoff process we had a step, which was removing `workspaces` keyword from `react-native` package. Without this keyword all new versions of packages will be resolved from npm (where they will be not available yet, because we have to publish them prior to it) This is not the case for our current setup, and we can actually bump packages versions and they will be resolved as a workspaces successfully Reviewed By: cortinico, cipolleschi Differential Revision: D44261057 fbshipit-source-id: 31c2157be2d3b33bc073651d6045efcef2e8f5c5
Contributor
|
@cortinico merged this pull request in 8f4542d. |
Contributor
Actually that command doesn't seems to work anymore (that's what we experienced on Friday last week). That's also what triggered this investigation and removal @hoxyq |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
While working on a couple things, me Riccardo and Nicola noticed that in main for some reason the old
align-package-versionscommand in the root package.json was still there in main branch.This was "merged into"
bump-all-updated-packagesby @hoxyq all the way back in March; here's the commit for 0.72 branch -> a469927We are not sure why, but for some reason the same commit in main was borked in some way, and didn't actually remove the command: PR (#36568) and commit (04df252)
So this commit just takes care of that.
Changelog:
[INTERNAL] [REMOVED] - remove old command for align packages versions
Test Plan:
N/A - it's a removal