Fix hashing function in event name mapping in PerformanceEntryReporter#36682
Closed
rshest wants to merge 1 commit into
Closed
Fix hashing function in event name mapping in PerformanceEntryReporter#36682rshest wants to merge 1 commit into
rshest wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44462195 |
Base commit: a83c192 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44462195 |
rshest
force-pushed
the
export-D44462195
branch
from
c8921ef to
52e0306
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44462195 |
rshest
force-pushed
the
export-D44462195
branch
from
52e0306 to
c2f2538
Compare
facebook#36682) Summary: Pull Request resolved: facebook#36682 ## Changelog: [Internal][Fix] - Fix hashing function in event name mapping in PerformanceEntryReporter A textbook mistake, when mapping event names via the constant lookup table, only the first 8 characters were effectively taken into account, thus mixing names of some events. Reviewed By: rubennorte Differential Revision: D44462195 fbshipit-source-id: d8845e74aa77b20d0fc66d3689836ca17a7213d5
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44462195 |
rshest
force-pushed
the
export-D44462195
branch
from
c2f2538 to
3c8ebe4
Compare
Contributor
|
This pull request has been merged in 9ccf85e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal][Fix] - Fix hashing function in event name mapping in PerformanceEntryReporter
A textbook mistake, when mapping event names via the constant lookup table, only the first 8 characters were effectively taken into account, thus mixing names of some events.
Reviewed By: rubennorte
Differential Revision: D44462195