Skip to content

Fix hashing function in event name mapping in PerformanceEntryReporter #36682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rshest wants to merge 1 commit into from
Closed

Fix hashing function in event name mapping in PerformanceEntryReporter #36682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/react-native/Libraries/WebPerformance/PerformanceEntryReporter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,10 +273,9 @@ void PerformanceEntryReporter::scheduleFlushBuffer() {

struct StrKey {
uint32_t key;
constexpr StrKey(const char *s)
: key(folly::hash::fnv32_buf(s, sizeof(s) - 1)) {}
StrKey(const char *s) : key(folly::hash::fnv32_buf(s, std::strlen(s))) {}

constexpr bool operator==(const StrKey &rhs) const {
bool operator==(const StrKey &rhs) const {
return key == rhs.key;
}
};
Expand Down