Fix podspec setup for 3rd parties when using dynamic linking#37275
Closed
cipolleschi wants to merge 2 commits into
Closed
Fix podspec setup for 3rd parties when using dynamic linking#37275cipolleschi wants to merge 2 commits into
cipolleschi wants to merge 2 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45523646 |
Base commit: e540d05 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45523646 |
cipolleschi
force-pushed
the
export-D45523646
branch
from
05d4a04 to
5c3a5e0
Compare
cipolleschi
force-pushed
the
export-D45523646
branch
from
5c3a5e0 to
03aba2b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45523646 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45523646 |
cipolleschi
force-pushed
the
export-D45523646
branch
from
03aba2b to
7ee5968
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45523646 |
cipolleschi
force-pushed
the
export-D45523646
branch
from
7ee5968 to
314fc6b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45523646 |
cipolleschi
force-pushed
the
export-D45523646
branch
from
314fc6b to
63b462d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45523646 |
cipolleschi
force-pushed
the
export-D45523646
branch
from
63b462d to
87e6111
Compare
…c image component and ImageManager (facebook#37276) Summary: Pull Request resolved: facebook#37276 When enabling dynamic linking, we had a circulr dependency between Fabric and the Image Manager. Specifically, Image Manager depends on Fabric, but the Image component, in Fabric, is using some implementation specific files from the Image Manager that surface only when enabling the dynamic linking. Xcode fails to find those symbols unless the dependencies are explicitly added to the podspec. This change is technically breaking, but we tried to minimize the breakage by adding the new pod in all the required search paths. ## Changelog [iOS][Breaking] - Add React-FabricImage pod. Differential Revision: https://internalfb.com/D45517278 fbshipit-source-id: 89c991bed7c170c6bb2f7f6e8b19ec64847f5454
…k#37275) Summary: Pull Request resolved: facebook#37275 When enabling `USE_FRAMEWORKS=dynamic`, we need to explicitly defines all the dependencies used by the pods. This change add those missing dependencies. ## Changelog: [iOS][Added] - Add explicit dependencies for 3rd parties libraries Reviewed By: NickGerleman Differential Revision: D45523646 fbshipit-source-id: f078e81c6bded0fcbdee34ab53fd1a8e55fb7e28
cipolleschi
force-pushed
the
export-D45523646
branch
from
87e6111 to
aa3118f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45523646 |
Contributor
|
This pull request has been merged in c027f0a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When enabling
USE_FRAMEWORKS=dynamic, we need to explicitly defines all the dependencies used by the pods.This change add those missing dependencies.
Changelog:
[iOS][Added] - Add explicit dependencies for 3rd parties libraries
Differential Revision: D45523646