Skip to content

Migrate to @rnx-kit/chromium-edge-launcher for Windows fix#41367

Closed
motiz88 wants to merge 1 commit into
facebook:mainfrom
motiz88:export-D51086297
Closed

Migrate to @rnx-kit/chromium-edge-launcher for Windows fix#41367
motiz88 wants to merge 1 commit into
facebook:mainfrom
motiz88:export-D51086297

Conversation

@motiz88
Copy link
Copy Markdown
Contributor

@motiz88 motiz88 commented Nov 7, 2023 •
edited
Loading

Summary: @acoates-ms graciously published the Windows Edge launcher fix from cezaraugusto/chromium-edge-launcher#1 as a new package (microsoft/rnx-kit#2796), so let's pull that into dev-middleware.

Changelog: [Internal] - Fix experimental debugger launch flow with Edge on Windows

Differential Revision: D51086297

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Nov 7, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Nov 7, 2023

This pull request was exported from Phabricator. Differential Revision: D51086297

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Nov 7, 2023

This pull request was exported from Phabricator. Differential Revision: D51086297

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Nov 7, 2023

This pull request was exported from Phabricator. Differential Revision: D51086297

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Nov 7, 2023

This pull request was exported from Phabricator. Differential Revision: D51086297

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Nov 7, 2023

This pull request was exported from Phabricator. Differential Revision: D51086297

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Nov 7, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,649,423 +0
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,033,027 +13
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 255fef5
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Nov 14, 2023

This pull request was exported from Phabricator. Differential Revision: D51086297

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Nov 14, 2023

This pull request was exported from Phabricator. Differential Revision: D51086297

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Nov 14, 2023

This pull request was exported from Phabricator. Differential Revision: D51086297

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Nov 15, 2023

This pull request was exported from Phabricator. Differential Revision: D51086297

@motiz88 @facebook-github-bot
Migrate to @rnx-kit/chromium-edge-launcher for Windows fix (facebook#…
a996653 
…41367)

Summary:

Andrew Coates graciously published the Windows Edge launcher fix from cezaraugusto/chromium-edge-launcher#1 as a new package (microsoft/rnx-kit#2796), so let's pull that into `dev-middleware`.

Changelog: [Internal] - Fix experimental debugger launch flow with Edge on Windows

Reviewed By: robhogan

Differential Revision: D51086297
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Nov 15, 2023

This pull request was exported from Phabricator. Differential Revision: D51086297

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Nov 15, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Nov 15, 2023

This pull request has been merged in 560e0f0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@motiz88 @facebook-github-bot @analysis-bot