Create fork of chromium-edge-launcher with fix for windows#2796
Merged
Conversation
tido64
reviewed
Nov 7, 2023
tido64
approved these changes
Nov 7, 2023
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Nov 15, 2023
…41367) Summary: Andrew Coates graciously published the Windows Edge launcher fix from cezaraugusto/chromium-edge-launcher#1 as a new package (microsoft/rnx-kit#2796), so let's pull that into `dev-middleware`. Changelog: [Internal] - Fix experimental debugger launch flow with Edge on Windows Reviewed By: robhogan Differential Revision: D51086297
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Nov 15, 2023
Summary: Pull Request resolved: #41367 Andrew Coates graciously published the Windows Edge launcher fix from cezaraugusto/chromium-edge-launcher#1 as a new package (microsoft/rnx-kit#2796), so let's pull that into `dev-middleware`. Changelog: [Internal] - Fix experimental debugger launch flow with Edge on Windows Reviewed By: robhogan Differential Revision: D51086297 fbshipit-source-id: 3a8db351f71eb31a9609c987cdb4dc66f24f9403
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recently metro took a dependency on chromium-edge-launcher to launch edge and attach it to a RN instance.
Unfortunately, there is a bug in chromium-edge-launcher which prevents it from correctly finding Edge on Windows machines. There has not been response from the maintainer, so we're forking it here to allow metro to bring in the fix.
Includes some typings and formatting fixes to allow compilation within the rnx-kit repo.