BridgelessUIManager: Finish createView, updateView, setChildren, manageChildren#42067
Closed
RSNara wants to merge 2 commits into
Closed
BridgelessUIManager: Finish createView, updateView, setChildren, manageChildren#42067RSNara wants to merge 2 commits into
RSNara wants to merge 2 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52345416 |
RSNara
force-pushed
the
export-D52345416
branch
from
e73f6d5 to
8d83825
Compare
RSNara
force-pushed
the
export-D52345416
branch
from
8d83825 to
0530fe8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52345416 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52345416 |
RSNara
force-pushed
the
export-D52345416
branch
from
0530fe8 to
6f4f989
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52345416 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52345416 |
RSNara
force-pushed
the
export-D52345416
branch
from
6f4f989 to
bdc58d9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52345416 |
RSNara
force-pushed
the
export-D52345416
branch
from
bdc58d9 to
7eed717
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52345416 |
RSNara
force-pushed
the
export-D52345416
branch
from
7eed717 to
35a9bc9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52345416 |
RSNara
force-pushed
the
export-D52345416
branch
from
35a9bc9 to
423ea8f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52345416 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52345416 |
RSNara
force-pushed
the
export-D52345416
branch
from
423ea8f to
fdbbee2
Compare
…Manager (facebook#41997) Summary: Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876
…geChildren (facebook#42067) Summary: These methods should not be implemented in the new architecture. The **only** code that called these UIManagerModule methods was the paper renderer. And the New Architecture should instead use the Fabric renderer. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52345416
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 10, 2024
…dren, manageChildren (facebook#42067) Summary: These methods should not be implemented in the new architecture. The **only** code that called these UIManagerModule methods was the paper renderer. And the New Architecture should instead use the Fabric renderer. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52345416
RSNara
force-pushed
the
export-D52345416
branch
from
fdbbee2 to
8b7c93c
Compare
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 10, 2024
…dren, manageChildren (facebook#42067) Summary: These methods should not be implemented in the new architecture. The **only** code that called these UIManagerModule methods was the paper renderer. And the New Architecture should instead use the Fabric renderer. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52345416
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 10, 2024
…dren, manageChildren (facebook#42067) Summary: These methods should not be implemented in the new architecture. The **only** code that called these UIManagerModule methods was the paper renderer. And the New Architecture should instead use the Fabric renderer. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52345416
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52345416 |
Contributor
|
This pull request has been merged in d825e7a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
These methods should not be implemented in the new architecture.
The only code that called these UIManagerModule methods was the paper renderer. And the New Architecture should instead use the Fabric renderer.
Changelog: [Internal]
Reviewed By: sammy-SC
Differential Revision: D52345416