Skip to content

RNTester iOS: Move Meta-internal setup to internal files#42073

Closed
fkgozali wants to merge 1 commit into
facebook:mainfrom
fkgozali:export-D52424748
Closed

RNTester iOS: Move Meta-internal setup to internal files#42073
fkgozali wants to merge 1 commit into
facebook:mainfrom
fkgozali:export-D52424748

Conversation

@fkgozali
Copy link
Copy Markdown
Contributor

@fkgozali fkgozali commented Dec 27, 2023

Summary:
This moved various Meta-internal runtime setup off AppDelegate.mm to reduce the #if checks throughout the file.

Changelog: [Internal]

Differential Revision: D52424748

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Dec 27, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52424748

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Dec 27, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,577,975 +6
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 19,955,023 -7
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 5416634
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52424748

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52424748

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52424748

@fkgozali fkgozali changed the title RNTester iOS: test-only flow: force enable bridgeless using experimental preprocessor flag RNTester iOS: Move Meta-internal setup to internal files Jan 2, 2024
)

Summary:

This moved various Meta-internal runtime setup off AppDelegate.mm to reduce the #if checks throughout the file.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D52424748
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52424748

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 2, 2024

This pull request was successfully merged by @fkgozali in 41d9ed0.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions Bot added the Merged This PR has been merged. label Jan 2, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in 41d9ed0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants