Skip to content

RNTester iOS: Move Meta-internal setup to internal files #42073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fkgozali wants to merge 1 commit into from
Closed

RNTester iOS: Move Meta-internal setup to internal files #42073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/react-native/Libraries/AppDelegate/RCTAppDelegate.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,11 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
return YES;
}

- (void)applicationDidEnterBackground:(UIApplication *)application
{
// Noop
}

- (NSURL *)sourceURLForBridge:(RCTBridge *)bridge
{
[NSException raise:@"RCTBridgeDelegate::sourceURLForBridge not implemented"
Expand Down
29 changes: 10 additions & 19 deletions packages/rn-tester/RNTester/AppDelegate.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#import "AppDelegate.h"

#import <React/RCTBundleURLProvider.h>
#import <React/RCTDefines.h>
#import <React/RCTLinkingManager.h>
#import <ReactCommon/RCTSampleTurboModule.h>
#import <ReactCommon/SampleTurboCxxModule.h>
Expand All @@ -21,26 +22,12 @@
#import <RNTMyNativeViewComponentView.h>
#endif

// FB-internal imports
#ifdef RN_DISABLE_OSS_PLUGIN_HEADER
#import <RCTFBAppInit/RCTFBAppInit.h>
#endif

#if BUNDLE_PATH
NSString *kBundlePath = @"xplat/js/RKJSModules/EntryPoints/RNTesterBundle.js";
#else
NSString *kBundlePath = @"js/RNTesterApp.ios";
#endif
static NSString *kBundlePath = @"js/RNTesterApp.ios";

@implementation AppDelegate

- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
#ifdef RN_DISABLE_OSS_PLUGIN_HEADER
// FB-internal app init setup.
RCTFBAppInitApplicationDidFinishLaunching(launchOptions);
#endif

self.moduleName = @"RNTesterApp";
// You can add your custom initial props in the dictionary below.
// They will be passed down to the ViewController used by React Native.
Expand All @@ -51,10 +38,7 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(

- (void)applicationDidEnterBackground:(UIApplication *)application
{
#ifdef RN_DISABLE_OSS_PLUGIN_HEADER
// FB-internal app backgrounding setup.
RCTFBAppInitApplicationDidEnterBackground(application);
#endif
[super applicationDidEnterBackground:application];
}

- (NSDictionary *)prepareInitialProps
Expand Down Expand Up @@ -131,6 +115,13 @@ - (void)application:(__unused UIApplication *)application

#endif

#pragma mark - New Arch Enabled settings

- (BOOL)bridgelessEnabled
{
return [super bridgelessEnabled];
}

#pragma mark - RCTComponentViewFactoryComponentProvider

#ifndef RN_DISABLE_OSS_PLUGIN_HEADER
Expand Down