Move codegen root directory from Libraries to src#42402
Closed
rubennorte wants to merge 3 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52919566 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52919566 |
rubennorte
force-pushed
the
export-D52919566
branch
from
3864889 to
997371f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52919566 |
rubennorte
force-pushed
the
export-D52919566
branch
from
997371f to
13eb234
Compare
Base commit: a758694 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52919566 |
rubennorte
force-pushed
the
export-D52919566
branch
from
13eb234 to
7869a8f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52919566 |
rubennorte
force-pushed
the
export-D52919566
branch
from
7869a8f to
50522ce
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52919566 |
rubennorte
force-pushed
the
export-D52919566
branch
from
50522ce to
241d4f2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52919566 |
rubennorte
force-pushed
the
export-D52919566
branch
from
241d4f2 to
d2b0ddf
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52919566 |
rubennorte
force-pushed
the
export-D52919566
branch
from
d2b0ddf to
5e3af20
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52919566 |
rubennorte
force-pushed
the
export-D52919566
branch
from
5e3af20 to
b9514a0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52919566 |
rubennorte
force-pushed
the
export-D52919566
branch
from
8053a3c to
c691ee8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52919566 |
rubennorte
force-pushed
the
export-D52919566
branch
from
c691ee8 to
d089701
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52919566 |
rubennorte
force-pushed
the
export-D52919566
branch
from
d089701 to
fc31df6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52919566 |
rubennorte
force-pushed
the
export-D52919566
branch
from
fc31df6 to
db40c6f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52919566 |
rubennorte
force-pushed
the
export-D52919566
branch
from
db40c6f to
9ab8256
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52919566 |
rubennorte
force-pushed
the
export-D52919566
branch
from
9ab8256 to
83c45f6
Compare
Summary: Pull Request resolved: facebook#42385 This adds support for having JS files in a `src` directory within the `react-native` package. The plan is to have 2 subdirectories there: * `react-native/src/private` for private modules, with any nested directories (e.g.: `react-native/src/private/dom/nodes/ReadOnlyNode.js`). * `react-native/src/public` for public modules, without nested directories. The plan is that the individual modules created in this directory will be public through the index module or directly via something like `react-native/View` (mapped to `react-native/src/public/View`, or a `dist` directory in the published npm package—details TBD). The enforcement of private modules being inaccessible from outside the `react-native` package will be added soon by huntie. Changelog: [internal] Reviewed By: huntie Differential Revision: D52875999 fbshipit-source-id: 58ee306f4fafd57ea73e9fd5c5401cce73013a26
Summary: Pull Request resolved: facebook#42386 The new DOM APIs are completely private at the moment, so they make them a good candidate to test the new directory structure (and make sure everything works correctly in CI, etc.). This moves those files to `src/private/dom`. Changelog: [internal] Reviewed By: huntie Differential Revision: D52875998 fbshipit-source-id: 945e80739b3afa535079ef24e6802f4d7780b565
Summary: Pull Request resolved: facebook#42402 Now that we have 2 top level directories for JS files in the `react-native` package, we need to choose where to put the native module and native component specs, because our current infra only supports a single directory. The options we had are: 1. Keep specs in the current directory (`Libraries`). This is a problem because it encourages us to keep adding modules in this "deprecated" directory. 2. Move specs to the new `src` directory. This requires moving the current files, but from now only we can create new specs in a private directory. 3. Modify the infra to allow multiple directories. This changes the public API for something it's likely only going to be used here. In this PR I went for option 2) because it's the most future-proof, even though it requires a little bit more work now. I created a script to automatically copy all the specs for modules and components to `src/private/specs/components` and `src/private/specs/modules`, and changed their current locations to serve as a proxy for the new location (to avoid breaking a potentially public API). `src/private/specs` isn't meant to be their final location. We should probably still colocate native module/component specs with the rest of their code, but we can do so when we move the code from `Libraries` to `src/private`. Changelog: [internal] Reviewed By: cortinico Differential Revision: D52919566 fbshipit-source-id: 79d2cc42bc49e2efa5c87c66975a46f469a70240
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52919566 |
rubennorte
force-pushed
the
export-D52919566
branch
from
83c45f6 to
dce8797
Compare
Contributor
|
This pull request has been merged in 5e8ce6c. |
Contributor
|
This pull request has been reverted by 692f727. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Changelog: [internal]
Differential Revision: D52919566