Relocate and refactor set-rn-version script#42730
Closed
huntie wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53001971 |
Summary: Pull Request resolved: facebook#42730 Reviewing and modernising this script as part of simplifying our release publish workflow. - Drop unused `--dependency-versions` arg from CLI entry point - Simplify templating approach - Type as Flow - Drop dependencies on `shelljs` and `yargs` - Relocate under `scripts/releases/` - Rewrite tests as snapshot tests Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D53001971 fbshipit-source-id: 34534a0fcbcf70832101105f4d18246c076308c8
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53001971 |
huntie
force-pushed
the
export-D53001971
branch
from
9db13e0 to
7858393
Compare
Contributor
|
This pull request has been merged in e97ba47. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Reviewing and modernising this script as part of simplifying our release publish workflow.
--dependency-versionsarg from CLI entry pointshelljsandyargsscripts/releases/Changelog: [Internal]
Reviewed By: NickGerleman
Differential Revision: D53001971