Skip to content

Enable Flow on misc release scripts#42736

Closed
huntie wants to merge 1 commit into
facebook:mainfrom
huntie:export-D53225162
Closed

Enable Flow on misc release scripts#42736
huntie wants to merge 1 commit into
facebook:mainfrom
huntie:export-D53225162

Conversation

@huntie
Copy link
Copy Markdown
Member

@huntie huntie commented Jan 30, 2024 •
edited
Loading

Summary:

Changelog: [Internal]

Differential Revision: D53225162

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 30, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 30, 2024

This pull request was exported from Phabricator. Differential Revision: D53225162

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Jan 30, 2024 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,181,011 -2
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,559,909 +11
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 2108269
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 30, 2024

This pull request was exported from Phabricator. Differential Revision: D53225162

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 30, 2024

This pull request was exported from Phabricator. Differential Revision: D53225162

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 30, 2024

This pull request was exported from Phabricator. Differential Revision: D53225162

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 30, 2024

This pull request was exported from Phabricator. Differential Revision: D53225162

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 30, 2024

This pull request was exported from Phabricator. Differential Revision: D53225162

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 30, 2024

This pull request was exported from Phabricator. Differential Revision: D53225162

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 30, 2024

This pull request was exported from Phabricator. Differential Revision: D53225162

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 31, 2024

This pull request was exported from Phabricator. Differential Revision: D53225162

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 31, 2024

This pull request was exported from Phabricator. Differential Revision: D53225162

@huntie @facebook-github-bot
Enable Flow on misc release scripts (facebook#42736)
f4ae93b 
Summary:

- Minimally enable Flow in these scripts. This would have caught outdated imports in D53001971 and D53228096.
- Update `publish-npm` script with async `main()` function.
- Also delete leftover `ReactNativeVersion.js.template` file.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D53225162
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 31, 2024

This pull request was exported from Phabricator. Differential Revision: D53225162

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 31, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 31, 2024

This pull request has been merged in b7b5585.

@huntie huntie deleted the export-D53225162 branch January 31, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huntie @facebook-github-bot @analysis-bot