[iOS][Fixed] Wrap UIMenuAutoFill in compilation pragmas for iOS 17 checks#43808
Closed
cipolleschi wants to merge 1 commit intomainfrom
Closed
[iOS][Fixed] Wrap UIMenuAutoFill in compilation pragmas for iOS 17 checks#43808cipolleschi wants to merge 1 commit intomainfrom
cipolleschi wants to merge 1 commit intomainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
force-pushed
the
cipolleschi/wrap-uimenuautofill-in-version-checks
branch
from
319b935 to
9f786d4
Compare
cipolleschi
force-pushed
the
cipolleschi/wrap-uimenuautofill-in-version-checks
branch
from
9f786d4 to
f8035b3
Compare
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 558f6ba |
Contributor
|
@cipolleschi merged this pull request in 1561cc9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
PR #43468 landed in main which uses UIMenuAutoFill that is available only in iOS 17.
Despite having the
@availablechecks, these are only runtime checks. The symbol is not stripped on older versions of Xcode and therefore our jobs which uses older Xcode versions started failing.This change wraps the offending code in a compilation pragma that strips away the symbol when building with Xcode versions that does not know iOS 17.
Changelog:
[iOS][Fixed] - wrap UIMenuAutoFill in compilation checks for iOS 17
Test Plan:
CircleCI is green